Repository navigation
fix(clusters): improve BYOC setup and profile design - #3155
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 18 files
Confidence score: 4/5
- In
profile-configuration-field.tsx, voice-control users may not be able to activate the add button by saying its visible label because thearia-labeluses different text. Make the accessible name include the visible label.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/clusters/feature/src/lib/cluster-profile/profile-configuration-field.tsx">
<violation number="1" location="libs/domains/clusters/feature/src/lib/cluster-profile/profile-configuration-field.tsx:230">
P3: The `aria-label` on the add button (`Add item to ${field.label}`) no longer contains the visible text (`arrayLabels.add`, e.g. 'Add taint'). Voice-control users who say the visible label will not match the control. Drop the `aria-label` so the accessible name comes from the visible text, or include the visible label in it.</violation>
</file>
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
|
View your CI Pipeline Execution ↗ for commit 86cd67a
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
All reported issues were addressed across 11 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #3155 +/- ##
===========================================
+ Coverage 54.42% 54.43% +0.01%
===========================================
Files 1424 1329 -95
Lines 31999 30057 -1942
Branches 9537 9278 -259
===========================================
- Hits 17415 16363 -1052
+ Misses 11844 11110 -734
+ Partials 2740 2584 -156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Confidence score: 5/5
- In
libs/domains/clusters/feature/src/lib/cluster-add/cluster-add.spec.tsx, the comment says the assertion covers a select, but the mocked flow renders no dropdowns; it only checks whether thefakeModalwrapper locks scroll. Update the comment to describe what the test actually verifies.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/clusters/feature/src/lib/cluster-add/cluster-add.spec.tsx">
<violation number="1" location="libs/domains/clusters/feature/src/lib/cluster-add/cluster-add.spec.tsx:102">
P3: The comment is inaccurate: this assertion never renders a select. The mocked creation flow has no dropdowns, so it only checks that the `fakeModal` wrapper in `ClusterAdd` doesn't lock scroll. Reword the comment to say that, or add a test that renders the real flow's selects and checks the lock there.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
rmnbrd
left a comment
rmnbrd
left a comment
There was a problem hiding this comment.
Well done! Thanks for this 🙏
|
🎉 This PR is included in version 1.379.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Improve BYOC cluster setup and profile settings: keep credential and region dropdowns scrollable within short viewports, layer nested modal overlays correctly, and align operator configuration fields and taint lists with the existing UI patterns.
Operator configuration: scope and rationale
The new
OperatorConfigurationFieldis dedicated to the Configure Qovery Operator step during BYOC setup. This modal needs full-width inputs with descriptions underneath and a taint list styled like organization settings, while the Profile page uses rows with labels on the left and inputs on the right. Keeping the modal presentation separate avoids adding operator-specific layout options and taint labels to the sharedProfileConfigurationField.The component supports only scalar fields and the node-group taint object array. It handles the taint empty state, summary rows, add/edit/remove actions, item limits, and validation errors. It reuses
SchemaFieldInput,ProfileArrayItemModal, and existing schema utilities rather than introducing another input or modal implementation. It updates local form values; the surrounding creation flow remains responsible for API operations. General nested-object and arbitrary-array editing are outside its scope.Screenshots
BYOC setup: consistent field spacing and a capped region dropdown that extends beyond the modal without being clipped.
Operator configuration: full-width inputs, descriptions beneath each field, and the dedicated taint empty state.
Profile settings: compact sidebar search, vertically centered inputs, tab underlines aligned with the divider, and a primary “Save and deploy” action.
Operator status: concise status and version details, with target versions retained below installed versions.
Validation
Focused cluster and shared UI tests passed during implementation. Added regression coverage for taint editing and operator status, plus Storybook examples for compact search, modal dropdowns, and stacked modals. Git diff whitespace check passed.
Tests and browser checks were not rerun for the final styling changes, as requested.
Summary by cubic
Improves BYOC cluster setup and profile settings: credential and region dropdowns stay scrollable inside short viewports, stacked modals dim correctly, and operator status and setup configuration match existing UI patterns.
InputSearchsize preserves default markup for existing callers.AGENTS.md.Written for commit 86cd67a. Summary will update on new commits.