Repository navigation
feat(2386): Add wide permissions to creation flow - #3156
mzottolaqovery wants to merge 8 commits into
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
|
View your CI Pipeline Execution ↗ for commit cb8a33f
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
d2e209b to
2b8562a
Compare
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Confidence score: 3/5
step-summary.tsxcan submit an AWS credential type that the wide-permission flow does not allow. Use the wide-permission credential selector or validate the credential type before submission.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.tsx">
<violation number="1" location="libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.tsx:137">
P2: This submits any selected AWS credential as `wide_permission_credentials`, although the existing wide-permission control permits only AWS role/STS credentials. Use the wide-permission credential selector or validate the selected credential type before building this request.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #3156 +/- ##
===========================================
+ Coverage 54.42% 54.49% +0.07%
===========================================
Files 1424 1428 +4
Lines 31999 32033 +34
Branches 9537 9555 +18
===========================================
+ Hits 17415 17457 +42
+ Misses 11844 11838 -6
+ Partials 2740 2738 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Could we share these controls between creation and editing? The field names, ordering, and credential creation behavior differ, so those differences should remain explicit, but sharing the common controls would keep validation and copy consistent. |
rmnbrd
left a comment
There was a problem hiding this comment.
Let's reuse the already existing components.
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Summary
Issue:
Screenshots / Recordings
For organizations with feature flag:
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-releaseSummary by cubic
Adds a restrictive-permissions mode to the AWS managed cluster creation flow so clusters run on restricted credentials by default and request extended credentials only when wider access is needed.
wide-credentialsPostHog feature flag for managed AWS clusters.using_restrictive_permissionsis registered on the form in both creation and edit flows.hooks.slack.comin both the creation flow and the edit-cluster credentials settings.cloud_provider_credentials, extended credentials aswide_permission_credentials, plus awide_permissionspayload block.Written for commit cb8a33f. Summary will update on new commits.