Skip to content

Correct two typos in exercise text (functions, python_by_example) - #638

Merged
mmcky merged 1 commit into
mainfrom
fix-exercise-typos
Nov 2, 2026
Merged

mmcky merged 1 commit into
mainfrom
fix-exercise-typos

Conversation

@mmcky

@mmcky mmcky commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Two small wording typos inside exercise blocks:

Lecture Before After
functions.md (Exercise 5) Rewrite the function factorial() in from [Exercise 1] using recursion. Rewrite the function factorial() from [Exercise 1] using recursion.
python_by_example.md (Exercise 2 hint) For the legend, noted that suppose var = 42, … For the legend, note that if var = 42, …

Copilot spotted both on QuantEcon/lecture-python-programming.ml#14. That edition keeps exercise blocks byte-for-byte identical to this repo, so the typos can only be corrected at the source.

On merge: the translation sync will open a small PR in each of the zh-cn, fa and fr editions for these two lectures. The ml edition is not on the sync, so it will be brought into line separately.

🤖 Generated with Claude Code

- functions.md: "Rewrite the function `factorial()` in from [Exercise 1]"
  -> "... `factorial()` from [Exercise 1]"
- python_by_example.md hint: "noted that suppose `var = 42`"
  -> "note that if `var = 42`"

Spotted by Copilot on QuantEcon/lecture-python-programming.ml#14, which
copies exercise blocks byte-for-byte from this repo, so the typos can
only be corrected here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes are limited to verified typo fixes in exercise text and do not affect MyST structure or code behavior.

Review effort: Lite
Findings: None

What changed in this PR

This PR fixes two minor wording typos inside MyST exercise/hint blocks in the lecture notes, improving clarity without changing any executable code or exercise structure.

Changes:

  • Fixes grammar in functions.md Exercise 5 (“in from” → “from”).
  • Fixes wording in python_by_example.md Exercise 2 hint (“noted that suppose” → “note that if”).
File Description
lectures/​functions.md Corrects a typo in Exercise 5 instructions for the recursive factorial() rewrite.
lectures/​python_by_example.md Corrects a typo in Exercise 2 hint text about f-strings used in a plot legend.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

@mmcky
mmcky merged commit cadd911 into main Nov 2, 2026
5 checks passed
@mmcky
mmcky deleted the fix-exercise-typos branch November 2, 2026 00:33
@mmcky

mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python-programming.zh-cn
Translation PR: QuantEcon/lecture-python-programming.zh-cn#143
Files synced (2):

  • lectures/functions.md
  • lectures/python_by_example.md

@mmcky

mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fr)

Target repo: QuantEcon/lecture-python-programming.fr
Translation PR: QuantEcon/lecture-python-programming.fr#101
Files synced (2):

  • lectures/functions.md
  • lectures/python_by_example.md

@mmcky

mmcky commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fa)

Target repo: QuantEcon/lecture-python-programming.fa
Translation PR: QuantEcon/lecture-python-programming.fa#176
Files synced (2):

  • lectures/functions.md
  • lectures/python_by_example.md

mmcky added a commit to QuantEcon/lecture-python-programming.ml that referenced this pull request Nov 2, 2026
Carries the English corrections from QuantEcon/lecture-python-programming#638
into this edition, so its exercise blocks stay byte-identical to the source
(the ruling on #12, applied in #14).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants