Repository navigation
move helper functions outside of [ - #7935
Open
ben-schwen wants to merge 1 commit into
Open
ben-schwen wants to merge 1 commit into
ben-schwen wants to merge 1 commit into
Conversation
ben-schwen
added this pull request to stack #7933
October 21, 2026 15:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## brk/a3_callenv #7935 +/- ##
==================================================
- Coverage 99.09% 99.09% -0.01%
==================================================
Files 88 88
Lines 17431 17422 -9
==================================================
- Hits 17273 17264 -9
Misses 158 158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-schwen
force-pushed
the
brk/a4_move_helpers
branch
from
October 24, 2026 10:13
94d7529 to
4821512
Compare
Functions defined inside [ capture its frame, so they block moving the code that uses them. Move them to internal top-level functions, named .dt_* so that conditions they raise still report the [.data.table call. No behaviour change.
ben-schwen
force-pushed
the
brk/a4_move_helpers
branch
from
October 24, 2026 23:13
4821512 to
296435e
Compare
|
No obvious timing issues in HEAD=brk/a4_move_helpers (Plot image upload to picrd.com failed; download the artifact below to view plots) Generated via commit 296435e Download link for the artifact containing the test results: ↓ atime-results.zip
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #852
Since this change consists of a lot code moving I would recommend reviewing it with
git diff brk/a4_move_helpers^! --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-changewhich displays the real changes nicely