Repository navigation
Remove serde_yaml due to lack of maintainance - #30
Merged
Merged
Conversation
This is a breaking change as the config and output were in yaml format. This is a result of the serde_yaml crate no longer being maintained.
The move away from yaml is considered a breaking change. This makes this a good time to update all of the packages used to build cpuinfo.
joshjob-scale
force-pushed
the
no_yaml
branch
from
October 15, 2026 00:00
e635a71 to
7179d7c
Compare
JSON has no hex literals, so CPUID leaves and MSR addresses had to be written in decimal (0x80000001 as 2147483649). Add serde helpers in src/hex.rs that read them from "0x..." strings as well as decimal, with '_' allowed as a separator, and convert config.json: values below 10 stay decimal, everything else is hex. A leaf repeated in one file (e.g. "0x7" and "7") is now an error instead of silently keeping the last one. Add a test that the built-in config parses. Output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jaguilera-scale
approved these changes
Oct 20, 2026
jd-aguilera
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serdes_yaml is no longer maintained and has been removed. At the same time all yaml support has been removed. The inputs and outputs are now only offered in json. Since this is a breaking change to those using this in scripts, the major version number was increased. That also seemed to have made this a good time to update packages across the board.
This implements #22