Repository navigation
add damping tutorial & exercise - #1
Conversation
xsaschako
left a comment
xsaschako
left a comment
There was a problem hiding this comment.
looks good to me, got minor comments, next time please specify in the PR what to look out for, thank youuu
There was a problem hiding this comment.
tutorial name doesn't adhere to prior naming scheme but maybe intentional?
There was a problem hiding this comment.
Would prefer to keep it aligned with the present naming scheme, but this would require to change it everywhere we mention the tutorials, i.e. documentation. Therefore we decided to name it like this. But not sure we want to keep it, maybe discuss?
| ax.plot(time, result_array[1 + int(osecir.InfectionState.InfectedSevere), :], label='Infected Severe') | ||
| ax.plot(time, result_array[1 + int(osecir.InfectionState.InfectedCritical), :], label='Infected Critical') | ||
|
|
||
| for t_damping, label in [(10, 'school + office closure'), (25, 'mask mandate'), |
There was a problem hiding this comment.
it renders for me ( nice graphic btw) but the annotations are slightly hard to read because they are on the lines of the states... I dont know how to fix it and maybe not necessary but maybe think abouztit
There was a problem hiding this comment.
Put them above the box. Better?
2 participants
No description provided.