Repository navigation
Conversation
dddd-zdf
changed the title
dddd-zdf
marked this pull request as ready for review
October 18, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some apps put their ExtensionKit extensions in
Extensions/, butAppBundleonly checksPlugIns/. This addsExtensions/to the search so those extensions are included in bundle lookup and signing preparation.Both directories are checked independently. The existing filtering stays the same, and a missing or unreadable directory doesn't prevent the other from being scanned.
Added tests for both locations, missing and unreadable directories, skipped entries, and bundle lookup. The existing archive tests also needed
import Foundationto compile.All 10 tests pass on macOS with Swift 6.1.2. The new tests also catch the missing extensions when run against the old code from a clean build: https://github.com/dddd-zdf/SideSign/actions/runs/39145543122
Upstream CI is waiting for maintainer approval. This revision has been live-tested on my device.