Repository navigation
refactor(scalarization): Extract shape check in scalarizers - #801
Merged
Merged
Conversation
COSMOS, PBI and STCH each repeated the same check that `weights` or `reference` has the shape of `values`. It is now done by `check_same_shape_as_values` in `scalarization/_utils.py`. The error messages are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ValerianRey
added
cc: refactor
github-actions
Bot
changed the title
ValerianRey
marked this pull request as ready for review
October 7, 2026 15:55
ValerianRey
enabled auto-merge (squash)
October 7, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COSMOS(weights),PBI(weights,reference) andSTCH(weights,reference) each repeated the same 6-line block checking that the tensor has the shape ofvalues. The 5 copies are replaced by a singlecheck_same_shape_as_valuesin a newscalarization/_utils.py.The error messages are unchanged: I compared them before and after for all 5 checks (plus the outputs of valid calls), and the scalarization tests pass.
🤖 Generated with Claude Code