Repository navigation
fix(linalg): Validate eps values in QuadprogProjector constructor - #818
Merged
ValerianRey merged 2 commits intoOct 7, 2026
Merged
Conversation
__init__ assigned the private attributes directly, so negative norm_eps and reg_eps were accepted at construction while the setters rejected them. The constructor now goes through the validating setters. Fixes SimplexLab#810 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SausageMan99
requested review from
a team,
PierreQuinton and
ValerianRey
as code owners
October 7, 2026 16:20
ValerianRey
added
cc: fix
ValerianRey
approved these changes
Oct 7, 2026
ValerianRey
left a comment
ValerianRey
left a comment
Member
There was a problem hiding this comment.
LGTM. Again very minor so no need for changelog entry imo
ValerianRey
enabled auto-merge (squash)
October 7, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810.
QuadprogProjector.__init__assigned_norm_epsand_reg_epsdirectly, bypassing the validation done in the setters. The constructor now goes through the setters, soQuadprogProjector(norm_eps=-1.0)raises the sameValueErrorasp.norm_eps = -1.0.Tested with two new tests in
tests/unit/linalg/test_dual_cone.py.This change was prepared with the help of an AI agent (Claude) and reviewed by me before opening.