Repository navigation
Run release-readiness on a hosted runner - #1797
Merged
Mikola Lysenko (mikolalysenko) merged 1 commit intoOct 28, 2026
Merged
Conversation
release-readiness is a ~10 s job (checkout, two reuse probes, release-lint.sh) that gates coverage, e2e-build and most of the run. On Depot it pays a host boot before any real work starts; in the slow-start episodes of #1512 that boot reached 307 s and pushed a merge_group run's ci-ok from ~8.7 to 11.5 min. Move it to ubuntu-latest, as #1747 did for ci-ok. The job needs only git, python3, bash and gh, all on the hosted image. The repo variable RELEASE_READINESS_RUNNER is the escape hatch if hosted Linux backs up. All needs: edges stay as they are. A scheduling test pins the runner. Fixes #1795 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011f9aeRFXYtAsVJCfxwhyiz
Collaborator
Author
|
bugbot run Generated by Claude Code |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0e49c68. Configure here.
Tanmay Singla (Tanmay182003)
approved these changes
Oct 28, 2026
Collaborator
Author
|
Ready for review at
Generated by Claude Code |
Mikola Lysenko (mikolalysenko)
deleted the
ci-perf/1795-hosted-release-readiness
branch
October 28, 2026 21:56
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1795
Problem
release-readinessis a ~10 s job (checkout, twoci-reuse-*.pyprobes,release-lint.sh) ondepot-ubuntu-24.04-4, andcoverage,e2e-build(and through it the e2e fan-out),test,node-addon,docker-baseand the cargo/yarn legs allneeds:it. In Depot slow-start episodes (#1512) its boot sits at the head of the critical path. From the issue (16:18–20:16 UTC, 20 runs): boot p50 31 s, p90 126 s, max 307 s; merge_group run for #1748 reachedci-okat 11.48 min, withrelease-readinessalone finishing at 5.32 min.Change
release-readinessruns on${{ vars.RELEASE_READINESS_RUNNER || 'ubuntu-latest' }}, mirroring what #1747 did forci-ok. The job only needs git, python3, bash and gh — all on the hosted image. Setting the repo variableRELEASE_READINESS_RUNNER(e.g.depot-ubuntu-24.04-4) moves it back with no merge. Noneeds:edge, output or step changes.scripts/tests/test_ci_scheduling.pygets a test pinning the runner, alongside the existingci-okone.Expected saving
From the issue's replay: merge_group #1748 11.48 → ~8.7 min; across 19 runs p90 −1.1 min, max −2.8 min; nothing in fast-host periods. ~0.1k Depot Linux job-min/day moves to free hosted minutes. No macOS/Windows change.
Measured result
This PR's run 40764064008 (pull_request, all 51 checks green):
`coverage` and `e2e-build` started right after it (e2e-build done at 1.40 min, coverage (2) at 4.83); `ci-ok` at 5.02 min. Total 44.7 job-min over 44 jobs. Depot was fast during this run (clippy boot 6 s), so this run shows the gate's floor rather than a slow-start saving; the saving shows in slow-start periods and in the merge queue, which the profiler will verify after merge.
Where each test runs
Unchanged. No job, step or test moved or skipped; only the host of one gate job changed. Required checks
ci-okandclippykeep their names andci-okstill needs every job (test_required_verdict_includes_every_job).Validation
python3 -B -m unittest discover -s scripts/tests: 376 tests OK.actionlint1.7.7 andzizmor --offlineonci.yml: same findings asorigin/main(37 / 59, all pre-existing), none new.Risk
If the hosted Ubuntu queue backs up as in #1372, this gate waits too; since #1747 the hosted queue for
ci-okhas stayed at 1–7 s. Escape hatch: theRELEASE_READINESS_RUNNERvariable. The previousDISABLE_DEPOT_RUNNERSswitch is moot for this job (it already selectedubuntu-latest).https://claude.ai/code/session_011f9aeRFXYtAsVJCfxwhyiz
Generated by Claude Code