Skip to content

Fix Maven home tests failing on Windows nightly #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Maven home tests failing on Windows nightly #1852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10bac33
Set USERPROFILE in Maven home tests on Windows
claude Oct 29, 2026
c8f2314
Redirect HOME and USERPROFILE in Maven home tests
claude Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions crates/socket-patch-core/tests/crawler_maven_e2e.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ use socket_patch_core::crawlers::maven_crawler::parse_pom_group_artifact_version
use socket_patch_core::crawlers::types::CrawlerOptions;
use socket_patch_core::crawlers::MavenCrawler;

/// The variables the crawler reads a user home from. Maven's `user.home`
/// prefers `USERPROFILE` on Windows and `HOME` elsewhere, while the
/// Coursier / Ivy lookups prefer `HOME` everywhere, so a test that points
/// the home at a temp dir must set both.
const HOME_VARS: [&str; 2] = ["HOME", "USERPROFILE"];

fn options_at(root: &Path) -> CrawlerOptions {
CrawlerOptions {
cwd: root.to_path_buf(),
Expand Down Expand Up @@ -269,10 +275,12 @@ async fn get_maven_repo_paths_home_dot_m2_fallback() {

let prev_local = std::env::var("MAVEN_REPO_LOCAL").ok();
let prev_m2 = std::env::var("M2_HOME").ok();
let prev_home = std::env::var("HOME").ok();
let prev_home = HOME_VARS.map(std::env::var_os);
std::env::remove_var("MAVEN_REPO_LOCAL");
std::env::remove_var("M2_HOME");
std::env::set_var("HOME", tmp.path());
for key in HOME_VARS {
std::env::set_var(key, tmp.path());
}

let crawler = MavenCrawler;
let paths = crawler
Expand All @@ -286,10 +294,11 @@ async fn get_maven_repo_paths_home_dot_m2_fallback() {
if let Some(v) = prev_m2 {
std::env::set_var("M2_HOME", v);
}
if let Some(v) = prev_home {
std::env::set_var("HOME", v);
} else {
std::env::remove_var("HOME");
for (key, value) in HOME_VARS.into_iter().zip(prev_home) {
match value {
Some(v) => std::env::set_var(key, v),
None => std::env::remove_var(key),
}
}

// Production returns exactly the single resolved repo path — assert the
Expand Down Expand Up @@ -340,10 +349,13 @@ async fn get_maven_repo_paths_global_mode_no_m2_returns_empty() {
let tmp = tempfile::tempdir().unwrap();
let prev_local = std::env::var("MAVEN_REPO_LOCAL").ok();
let prev_m2 = std::env::var("M2_HOME").ok();
let prev_home = std::env::var("HOME").ok();
let prev_home = HOME_VARS.map(std::env::var_os);
std::env::remove_var("MAVEN_REPO_LOCAL");
std::env::remove_var("M2_HOME");
std::env::set_var("HOME", tmp.path()); // No .m2/ inside
// No .m2/ inside.
for key in HOME_VARS {
std::env::set_var(key, tmp.path());
}

let crawler = MavenCrawler;
let opts = CrawlerOptions {
Expand All @@ -359,10 +371,11 @@ async fn get_maven_repo_paths_global_mode_no_m2_returns_empty() {
if let Some(v) = prev_m2 {
std::env::set_var("M2_HOME", v);
}
if let Some(v) = prev_home {
std::env::set_var("HOME", v);
} else {
std::env::remove_var("HOME");
for (key, value) in HOME_VARS.into_iter().zip(prev_home) {
match value {
Some(v) => std::env::set_var(key, v),
None => std::env::remove_var(key),
}
}

assert!(
Expand Down
Loading