[Mikola Lysenko (mikolalysenko)]

LLM Description written by Claude Code:claude-opus-5-5

Architecture sweep of crates/socket-patch-cli/src/commands/vex_consumed.rs and vex_sources.rs. These are the next free rows in coverage/files.tsv, and their notes are tracked in the architecture discussion #1830. No open PR touches either file. vex.rs (held by #1698 and #1893) is not changed.

Changes

vex_consumed.rs

• Deleted the not_installed() wrapper (9 call sites now use HostedCopies::default()).
• Deleted the cfg(test) forwarder npm_identity_fallback. The _reusing variant takes its name, and the two docs are merged.
• Removed comments: 3 section banners and 5 bare issue refs (#599, #1098, #1494 ×2, #856).
• Tests:
  • Fixed the stale doc on npm_identity_fallback_fills_only_misses. It said the targeted lookup probes only node_modules/left-pad, which is no longer true; it now says what the asserts check.
  • Rewrote the garbled vlt_alias_is_consumed_through_its_store_copy doc ("no importer dir is an alias nothing").
  • Deleted the write_pkg wrapper and reused local() for an inline CrawlerOptions.
  • Moved npm_alias_copies_finds_only_alias_installs and npm_alias_copies_walks_every_workspace_members_tree to ecosystem_dispatch tests. They test find_manifest_package_copies_reusing, and are renamed manifest_copies_take_npm_alias_installs_only and manifest_copies_walk_every_npm_workspace_members_tree. Their new write_package_json helper is now also behind write_npm_package.

vex_sources.rs

• Inlined recognized_dead_note into its only caller, dead_claim_notes, which is now one loop.
• Deleted the note() forwarder. The 10 call sites now build PlanNote { code, detail } directly.
• Made 12 NOTE_* consts private, since nothing outside the module uses them. NOTE_API_AUTH_FALLBACK stays pub(crate).
• Moved the 3 unattested-note consts (NOTE_NPM_SHRINKWRAP_ONLY, NOTE_MAVEN_REACTOR_ROOT, NOTE_MAVEN_CLASSIFIER_UNPATCHED) up beside their siblings, above unattested_note.
• Removed comments: 3 section banners and 3 bare refs (#745, #899, #261).

Audit notes not applied

• Inline fetch_concurrency and build_candidates: /code-review high objected to both. fetch_concurrency's test is the only check of this window's own FETCH_CONCURRENCY ceiling. build_candidates names a step, and inlining it would add 20 lines to plan(), which is already about 350.
• Drop the failed() wrapper: it is kept. It does &str→String for 19 call sites, and each 4-line literal would replace a one-liner.
• Move api_auth_fallback_warning to json_envelope; merge PlanNote into RunWarning: both change callers in vendor.rs and apply.rs (Fix Go patch delivery, audits, and reinstalls #1698), repair.rs (Sweep remove.rs and repair.rs #1875) and vex.rs (Fix Go patch delivery, audits, and reinstalls #1698/Fix Go stale go.sum line after a downgrade (#1862) #1893), so they wait.
• Move the store-variants test to core npm_crawler.rs: that file is held by Fix hidden npm workspace members left unpatched (#1827) #1829, Build: share one test env guard in core (#1889) #1891, Fix crawlers missing parent dirs under --cwd . (#1902) #1906 and Fix .yarnrc read by two drifted tokenizers (#1901) #1915.
• Remove the cfg(test) import swap that records store-variant expansion: kept. It is the only way the hosted tests can assert that already-expanded copies are not rescanned.

/code-review high

There were no correctness findings and 7 cleanup or test-coverage notes. 6 are fixed:

• restored fetch_concurrency and its test;
• restored build_candidates;
• inlined the re-created manifest_copies wrapper;
• kept the "no second alias walk" reason;
• renamed the moved tests;
• write_npm_package now shares the package.json writer.

1 is left: a sorted helper now exists in two different test modules. A shared test-util module for one three-line helper isn't worth it.

Stats

git diff --stat: 3 files, +247 / −285.

• Production: +104 / −141 (net −37). Most of the + lines in vex_sources.rs come from the PlanNote literals that replace note().
• Tests: +146 / −144. Most of that is the two tests moving to ecosystem_dispatch.rs.

Verification

• cargo clippy --workspace --all-features -- -D warnings is clean.
• cargo test -p socket-patch-cli --lib: 940 passed.
• The vex, e2e_vex, e2e_embedded_vex, e2e_vex_redirect and e2e_vex_vendor suites all pass (234 tests).
• No platform-specific code changed.
• CI: ci-ok green on 14ba988; Bugbot found no issues.

Behavior change

None. Output bytes, JSON, warning codes and exit codes are unchanged.

Risk

Low: local inlining and comment and visibility changes only.

https://claude.ai/code/session_011f9aeQ8265a5x29iqeryUU

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

BugBot review

---

Generated by Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 14ba988. Configure here.}

[Mikola Lysenko (mikolalysenko)]

[burn-down agent] Ready for review at 14ba988.

• CI: 82/82 check runs on 14ba988 green (success/skipped/neutral); no main-wide failures.
• Bugbot: reviewed 14ba988, no findings; no open review threads.
• Mergeable, no conflicts with main; no CHANGELOG.md change.

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

Final review brief

What it does: A behavior-preserving cleanup of vex_consumed.rs and vex_sources.rs. It inlines the not_installed(), note() and recognized_dead_note wrappers and the test-only npm_identity_fallback forwarder, and makes 12 NOTE_* consts private. It also moves two alias-install tests into ecosystem_dispatch tests, where the function they exercise lives.

Risk: low. Every production change is a mechanical inline. Note codes, message text and ordering are unchanged. Narrowing the consts to private compiles, so nothing else used them.

Look here:

• vex_sources.rs:894-923:`` dead_claim_notes, the only control-flow rewrite (filter_map/map became a for/continue loop).
• vex_sources.rs:179-234:``` the visibility narrowing and the moved consts.
• vex_consumed.rs:145-171:```` npm_identity_fallback (formerly `_reusing`), with the production call at :99.
• ecosystem_dispatch.rs:2259-2380:````` the moved tests and their new helpers.

Verified:

• Read the full diff against main.
• Assertions in the moved tests are byte-identical to the originals.
• cargo test -p socket-patch-cli --lib -- vex_consumed vex_sources ecosystem_dispatch: 71 passed.
• cargo test -p socket-patch-cli --test e2e_vex: 45 passed.
• clippy (lib/bins, test profile): clean.
• CHANGELOG.md is untouched.
• CI: ci-ok and clippy are green on the head.

Changes I made: In the PR description, corrected "12 call sites" to 10 for note().

Open questions: None. A small sorted() test helper is now duplicated in two test modules; the description acknowledges this.

Auto-merge is armed: approving sends this straight to the merge queue.

---

Generated by Claude Code

[Wenxin Jiang (Wenxin-Jiang)]

[agent] Reviewed 14ba988283c739b8fc6e0823d4f77f846aaa9b94. Checked VEX consumed-copy fallback reuse, authority/liveness notes and equivalent record-fetch outcomes. No major correctness issues found. Validation: source and regression-test review plus the available exact-head CI checks; no local test pass is claimed.