feat(sidebar): list PostgreSQL sequences and set or edit them by datlechin · Pull Request #3722 · TableProApp/TablePro

datlechin · 2026-10-20T21:12:27Z

Summary

PostgreSQL listing reads relkind S on macOS, so each schema gets a Sequences section; the row tooltip names the owning column (OWNED BY).
Set Next Value… runs setval, to a typed value or past the values already in the owning column.
Edit Sequence… runs ALTER SEQUENCE for increment, min, max, cache and cycle.
Both sheets show their SQL first and run through Safe Mode. New Sequence… opens a query tab with a CREATE SEQUENCE template.
The commands are in the sidebar row menu, the + menu and the Database menu.
PluginKit (kit 40, additive): PluginTableInfo owner fields, PluginSequenceDetails, and driver hooks with defaults for details, setval, ALTER SEQUENCE and the create template.
Export, Compare and Copy To skip the sequence rows the listing now returns.
Fix: a sequence's DDL kept AS <type> and CACHE out, so an export restored it as bigint with cache 1.
The database tool commands move to MainContentCommandActions+DatabaseTools.swift: New Sequence put the class over SwiftLint's 1100-line body limit.
Tests updated on purpose:
- PostgreSQLFetchTablesAllSchemasTests: the macOS listing reads relkind S.
- SidebarObjectKindTests: .sequence joins the table category.
- WindowSidebarStateTests (unknown object kind): the fixture's unknown kind is synonym, since sequence is now known.
- DatabaseMenuCommandTests (New Folder): New Folder follows New Sequence.
- DiagramPointerUITests: opens the diagram from the sidebar's empty-area menu; the longer Database menu puts View ER Diagram under its scroll arrow on the 1024x768 runner.

Test plan

PostgreSQLSequenceBrowsingTests, SequenceSidebarTests, the new DatabaseTreeMenuSpecTests and MainMenuValidationTests cases fail on main and pass here.
Probed on PostgreSQL 17.11: listing with owners, details, DDL, setval past the column's max.
verify.sh: build, lint, the sidebar, menu and PostgreSQL suites (405 passed).

Docs: TableProApp/docs#78

Fixes #3605

…s start

…quences # Conflicts: # apple/TablePro/Core/Database/DatabaseObjectToolEligibility.swift

…nner change on main

…quences

…View+StatusBar

…quences

…quences # Conflicts: # apple/TablePro/Views/Main/Child/MainEditorContentView.swift

…ce kind and menu items moved

…quences

…quences # Conflicts: # apple/TablePro/Core/Database/DatabaseObjectToolEligibility.swift

…quences # Conflicts: # apple/TablePro/Resources/Localizable.xcstrings

…quences

…ommandActions+DatabaseTools

J2TeamNNL

Review notes. Not built or run locally.

J2TeamNNL · 2026-10-21T09:29:53Z

+            let afterColumn = "COALESCE(pg_catalog.\(descending ? "min" : "max")(\(quotedColumn))::bigint + \(increment), \(start))"
+            // Never behind where the sequence already is: another session may hold values cached past it.
+            let current = "(SELECT CASE WHEN is_called THEN last_value + \(increment) ELSE last_value END FROM \(relation))"
+            let value = "\(descending ? "LEAST" : "GREATEST")(\(afterColumn), \(current))"


The option "After the values already in " wraps the value in GREATEST (LEAST when descending) with the current position. It can never move the sequence back. After a delete or truncate, picking it reports success and the sequence stays high. Only the typed value can lower it.

J2TeamNNL · 2026-10-21T09:29:53Z

+            // and with row security off a policy that would hide rows fails the read instead.
+            let rowSecurity = hasRowSecurity ? "SET LOCAL row_security = off;\n" : ""
+            return rowSecurity
+                + "LOCK TABLE \(source) IN SHARE ROW EXCLUSIVE MODE;\n"


LOCK TABLE ... IN SHARE ROW EXCLUSIVE MODE needs UPDATE, DELETE or TRUNCATE on the table. A role with only INSERT or SELECT fails with permission denied, and this is the default option for owned sequences. There is no fallback and the sheet gives no hint why.

J2TeamNNL · 2026-10-21T09:29:53Z

            let kind = PluginExportObjectKind.from(tableType: table.type.rawValue)
            guard request.kinds.contains(kind) else { return nil }
+            // A sequence holds no rows worth a file, and a role with USAGE alone cannot read it.
+            if table.type == .sequence, !request.kinds.contains(.sequence) { return nil }


PluginExportObjectKind.from(tableType:) has no sequence case, so a SEQUENCE row is still classified as a table. The name dedupe only runs when loadSequences returns rows. If it returns [] (fetch failed or pg_sequences not visible), the sequence is exported as SELECT * data. Fixing the classification in from(tableType:) would remove the need for the guard.

J2TeamNNL · 2026-10-21T09:29:53Z

        return definitions.map { PluginSequenceInfo(name: $0.name, ddl: $0.ddl, schema: schemaName) }
    }

+    func fetchSequenceDetails(sequence: String, schema: String?) async throws -> PluginSequenceDetails? {


fetchSequenceDetails returns nil when no definition matches, and SequenceEditing.details turns that into unsupported. If another session drops the sequence, or the role cannot see it, the user gets an unsupported error. Not found and not supported should be different errors. Also, opening the sheet runs up to three sequential round trips, and the position query does not depend on the definition, so it could run concurrently.

J2TeamNNL · 2026-10-21T09:29:53Z

+    // 'a' for OWNED BY, 'i' for an identity column's own sequence.
+    var ownerDependency: String?

    func withLastValue(_ value: String?) -> PostgreSQLSequenceDefinition {


The five new fields are vars with no initializer parameters, so withLastValue has to copy each by hand. A field added later and missed there is dropped silently on the pre-10 path. Making them let initializer parameters, or copying self and replacing lastValue, avoids that.

J2TeamNNL · 2026-10-21T09:29:53Z

        }
    }

+    private static func ownerColumns(sequence: String) -> String {


ownerColumns(sequence:) rewrites the owner subqueries that PostgreSQLTableListing.sequenceOwnerColumns already holds. A change to how ownership is read must be made in two places, and the sidebar tooltip and the sheet can then disagree.

J2TeamNNL · 2026-10-21T09:29:54Z

                action: #selector(MainSplitViewController.editObjectComment(_:))
            ),
+            MenuItemFactory.item(
+                String(localized: "Set Next Value…"),


Three always-present items (New Sequence, Set Next Value, Edit Sequence) are added to the Database menu for every engine, and the menu now scrolls on the 1024x768 UI test runner. The PR rewrites DiagramPointerUITests to work around it. AGENTS.md says to fix the code, not the test, and a deliberate test change must be named in the description.

J2TeamNNL · 2026-10-21T09:29:54Z

        var result: PluginQueryResult?
+        var answered = PostgreSQLTableListingLadder.leastCapableAttempt
        for attempt in PostgreSQLTableListingLadder.degradableAttempts where result == nil {
            do {


Sequences now come back from fetchTables, which every consumer shares. Compare, ObjectCopyCatalog, export and transfer were patched, but autocomplete (SQLSchemaProvider), MCP list_tables and schema search, AI QueryContextBuilder and RowImportSheet were not. They now see tables whose columns are last_value, log_cnt and is_called. Each future consumer needs the same filter.

J2TeamNNL · 2026-10-21T09:35:53Z

Fixes for the review notes, in one commit: J2TeamNNL@db8800a

Fixed:

After the values already in the column: the GREATEST/LEAST guard is gone, so the option can lower the sequence.
LOCK TABLE: the statement now takes the lock only if the role has UPDATE, DELETE or TRUNCATE on the table, so INSERT-only roles no longer fail.
Sequence dropped or hidden: fetchSequenceDetails throws "no longer exists" instead of returning nil. The position read now runs alongside the definition read.
withLastValue copies self and replaces two fields, so a new field cannot be dropped.
Owner subqueries: the sheet reuses PostgreSQLTableListing.sequenceOwnerColumns, one definition for both.
Database menu: the three sequence rows are removed (the sidebar and its add menu keep them). DiagramPointerUITests is back to its main version.
Other consumers: autocomplete, MCP list_tables and schema search/resource, and AI context now skip sequences.

Skipped:

PluginExportObjectKind.from(tableType:) sequence case: MariaDB lists its sequences only through the table listing and exports them as data (pinned by exportKeepsAnUnlistedSequence). A sequence kind there would export with no DDL. On PostgreSQL a failed sequence read still exports the one state row, as before.
RowImportSheet: it already filters with acceptsImportedRows.

Not built or run locally; only swiftc -parse on the touched files.

To take it: git fetch https://github.com/J2TeamNNL/TablePro review-fix/3722 && git cherry-pick db8800ab08762343934271064962d5fc40d10762

…quences # Conflicts: # apple/TablePro/Core/Plugins/PluginDriverAdapter.swift # apple/TablePro/Models/Query/QueryResult.swift

…quences # Conflicts: # apple/TablePro/Resources/Localizable.xcstrings # apple/TablePro/Views/Sidebar/DatabaseTreeOutlineCoordinator+Commands.swift

…Tests+Sequences

…quences

…quences # Conflicts: # apple/TablePro/Views/Main/MainContentCommandActions.swift

datlechin added 2 commits October 21, 2026 04:12

feat(sidebar): list PostgreSQL sequences and set or edit them

ddbab7c

docs(changelog): note PostgreSQL sequences in the sidebar

83f2828

datlechin mentioned this pull request Oct 20, 2026

docs(features): PostgreSQL sequences in the sidebar TableProApp/docs#78

Merged

datlechin added 4 commits October 21, 2026 04:27

fix(sidebar): show where a sequence stands after setval instead of it…

97fdea2

…s start

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

1a94c45

…quences # Conflicts: # apple/TablePro/Core/Database/DatabaseObjectToolEligibility.swift

fix(sidebar): run sequence changes in the target's scope after the ru…

e7f4a67

…nner change on main

test(sidebar): keep the menu spec suite under the type body limit

12fda1f

datlechin enabled auto-merge (squash) October 20, 2026 22:48

datlechin added 11 commits October 21, 2026 05:52

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

6ef5701

…quences

refactor(editor): move the editor's status bar into MainEditorContent…

0359968

…View+StatusBar

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

e4dfd8d

…quences

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

6c4ba8f

…quences # Conflicts: # apple/TablePro/Views/Main/Child/MainEditorContentView.swift

fix(sidebar): keep Types the last section and update tests the sequen…

12a138d

…ce kind and menu items moved

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

d2fd796

…quences

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

ff344b1

…quences # Conflicts: # apple/TablePro/Core/Database/DatabaseObjectToolEligibility.swift

Merge branch 'main' into feat/3605-postgres-sequences

56eb0d4

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

16779dc

…quences # Conflicts: # apple/TablePro/Resources/Localizable.xcstrings

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

bd61904

…quences

refactor(commands): move the database tool commands into MainContentC…

2e4fad9

…ommandActions+DatabaseTools

J2TeamNNL reviewed Oct 21, 2026

View reviewed changes

datlechin added 5 commits October 21, 2026 17:13

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

add2a5e

…quences # Conflicts: # apple/TablePro/Core/Plugins/PluginDriverAdapter.swift # apple/TablePro/Models/Query/QueryResult.swift

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

cb72035

…quences # Conflicts: # apple/TablePro/Resources/Localizable.xcstrings # apple/TablePro/Views/Sidebar/DatabaseTreeOutlineCoordinator+Commands.swift

test(sidebar): move the sequence menu cases into DatabaseTreeMenuSpec…

d187bdd

…Tests+Sequences

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

0a464e6

…quences

Merge remote-tracking branch 'origin/main' into feat/3605-postgres-se…

a5c50af

…quences # Conflicts: # apple/TablePro/Views/Main/MainContentCommandActions.swift

datlechin merged commit b47493e into main Oct 21, 2026
8 checks passed

datlechin deleted the feat/3605-postgres-sequences branch October 22, 2026 07:05

Navigation Menu

Repository navigation

feat(sidebar): list PostgreSQL sequences and set or edit them - #3722

feat(sidebar): list PostgreSQL sequences and set or edit them#3722
datlechin merged 22 commits into
mainfrom
feat/3605-postgres-sequences

datlechin commented Oct 20, 2026 •

edited

Loading

Uh oh!

J2TeamNNL left a comment

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL Oct 21, 2026

Uh oh!

J2TeamNNL commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

datlechin commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

J2TeamNNL left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

J2TeamNNL commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datlechin commented Oct 20, 2026 •

edited

Loading