Skip to content

fix(ci): support Changesets v3 in version previews - #422

Merged
benjavicente merged 4 commits into
TanStack:mainfrom
benjavicente:fix-changeset-preview-v3
Oct 17, 2026
Merged

benjavicente merged 4 commits into
TanStack:mainfrom
benjavicente:fix-changeset-preview-v3

Conversation

@benjavicente

@benjavicente benjavicente commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

#414 and TanStack/query#11583 upgraded changesets to v3, and with the upgrade, I'm getting issues on the angular pre-release branch.

This PR updates @changesets/get-release-plan and @changesets/action matching the upgrade guide (links point to the section in the guide). It also updates the pnpm version mentioned in the readme, and the name of the output name of the action.

I didn't find any major issues outside the prerelease workflow. It ignores a PR comments like here: https://github.com/TanStack/config/actions/runs/38833780698/job/116758200847#step:6:16 in the release #420 . You can see in the run that 0.3.5 was published but the step that uses an output does not detect it.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated release automation configuration for publishing and release comments.
    • Release comments can now use the default GitHub token when a custom token is not provided.
    • Release comments can locate the repository using the standard GitHub repository setting when a custom repository setting is unavailable.
  • Documentation
    • Updated the release workflow example to match the current configuration.
    • Updated development setup instructions to specify pnpm v12.

@benjavicente
benjavicente requested a review from a team as a code owner October 17, 2026 16:54
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de4a3a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit de4a3a7

Command Status Duration Result
nx run-many --target=build ✅ Succeeded <1s View ↗
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-17 18:10:34 UTC

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0741344c-b5b2-4f22-9d98-f8729a32dec2
📥 Commits

Reviewing files that changed from the base of the PR and between b576b5b and de4a3a7.

📒 Files selected for processing: 4
  • .github/comment-on-release/README.md
  • .github/comment-on-release/action.yml
  • .github/comment-on-release/comment-on-release.ts
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The Changesets dependency and release workflow configuration were updated. The release comment action now has token and repository fallbacks. The contributor instructions now specify pnpm v12.

Changes: Release automation

Layer / File(s) Summary
Changesets release updates
.github/changeset-preview/package.json, .github/workflows/release.yml, .github/comment-on-release/README.md
The release-plan dependency changed to ^5.0.0. The workflow and example use updated Changesets action inputs and the published-packages output. The workflow passes the token through github-token and adds issues: write permission.
Release comment configuration
.github/comment-on-release/action.yml, .github/comment-on-release/comment-on-release.ts
The comment action uses github.token when GH_TOKEN is empty or unset. The action uses GITHUB_REPOSITORY when REPOSITORY is empty or unset.

Contributor instructions

Layer / File(s) Summary
pnpm version documentation
CONTRIBUTING.md
The documented package-management version changed from pnpm v9 to v12.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley

Merge Risk: ⚪ Minimal · up to de4a3

The release workflow and contributor setup changes are consistent with the supported Changesets and pnpm configurations.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the primary CI change: support for Changesets v3 in version previews.
Description check Passed The description explains the Changesets v3 migration, related workflow fixes, affected files, and release impact. It includes the required sections. The local testing checklist item remains unchecked,…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the Changesets v3 migration, related workflow fixes, affected files, and release impact. It includes the required sections. The local testing checklist item remains unchecked, but the description is otherwise complete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@tanstack/eslint-config@422
npm i https://pkg.pr.new/@tanstack/publish-config@422
npm i https://pkg.pr.new/@tanstack/typedoc-config@422
npm i https://pkg.pr.new/@tanstack/vite-config@422

commit: de4a3a7

@socket-security

socket-security Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​changesets/​get-release-plan@​4.0.16 ⏵ 5.0.210010067 -794100

View full report

Comment thread .github/comment-on-release/README.md Outdated
GitHub Actions provides GITHUB_REPOSITORY, but the comment script only
checked REPOSITORY. This skipped release notifications even when a valid
published package list was supplied. Use the standard variable as a
fallback while retaining the existing override.

An explicitly empty GH_TOKEN input also bypasses the composite action's
default. Fall back to github.token for comments and grant issues: write
for linked-issue notifications. Document that the release workflow still
requires its custom token; this fallback applies only to comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants