You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Respect selected partners in starter analysis - #1402
An explicit Clerk selection paired with a WorkOS mention could return WorkOS in inferredPartnerIds while the recipe correctly kept Clerk. Pass the selected partners into the existing inference filter so the analysis respects the same constraints.
AI review notes:
Reproduced through analyzeApplicationStarterServer using a composed input with Clerk selected and “Build an app with WorkOS authentication.” as the brief. Before: inferred WorkOS, recipe Clerk. After: no conflicting inferred partner, recipe Clerk.
Adds a regression covering the actual analysis result and recipe. Full pnpm test and the normal commit hook passed.
Follows up on the separate inference concern from the CodeRabbit review on #998. That PR's Lovable activation change was already covered by main.
Summary by CodeRabbit
Bug Fixes
Improved application setup recommendations by preserving explicitly selected partners when they are compatible with the requested integration.
Prevented incompatible authentication options from appearing in the resulting setup recipe when a supported partner is selected.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: fdb4cb77-b110-4e5f-9dbe-80808082a7d4
📥 Commits
Reviewing files that changed from the base of the PR and between bce7f7e and 766b336.
📒 Files selected for processing: 2
src/utils/application-starter.server.ts
tests/application-starter-partners.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
Server-side application-starter analysis now derives inferred partner IDs using selected partner IDs and compatible partners. A test covers selecting Clerk for a WorkOS authentication request.
Changes: Partner inference
Layer / File(s)
Summary
Derive inferred partners and test selection src/utils/application-starter.server.ts, tests/application-starter-partners.test.ts
Partner inference uses selected partner IDs with the compatible-partner set. The test verifies that selecting Clerk retains Clerk, infers no partners, and excludes WorkOS from the resulting recipe.
The partner inference change addresses the conflicting-selection case, with no concrete merge-blocking risk identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: preserving explicitly selected partners during starter analysis.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit Clerk selection paired with a WorkOS mention could return WorkOS in
inferredPartnerIdswhile the recipe correctly kept Clerk. Pass the selected partners into the existing inference filter so the analysis respects the same constraints.Summary by CodeRabbit