Skip to content

Respect selected partners in starter analysis - #1402

Open
tannerlinsley wants to merge 1 commit into
mainfrom
taren/starter-analysis-partner-constraints
Open

tannerlinsley wants to merge 1 commit into
mainfrom
taren/starter-analysis-partner-constraints

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

An explicit Clerk selection paired with a WorkOS mention could return WorkOS in inferredPartnerIds while the recipe correctly kept Clerk. Pass the selected partners into the existing inference filter so the analysis respects the same constraints.

AI review notes:
Reproduced through analyzeApplicationStarterServer using a composed input with Clerk selected and “Build an app with WorkOS authentication.” as the brief. Before: inferred WorkOS, recipe Clerk. After: no conflicting inferred partner, recipe Clerk.
Adds a regression covering the actual analysis result and recipe. Full pnpm test and the normal commit hook passed.
Follows up on the separate inference concern from the CodeRabbit review on #998. That PR's Lovable activation change was already covered by main.

Summary by CodeRabbit

  • Bug Fixes
    • Improved application setup recommendations by preserving explicitly selected partners when they are compatible with the requested integration.
    • Prevented incompatible authentication options from appearing in the resulting setup recipe when a supported partner is selected.

@tannerlinsley
tannerlinsley requested a review from a team October 20, 2026 07:37
@changeset-bot

changeset-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 766b336

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fdb4cb77-b110-4e5f-9dbe-80808082a7d4
📥 Commits

Reviewing files that changed from the base of the PR and between bce7f7e and 766b336.

📒 Files selected for processing: 2
  • src/utils/application-starter.server.ts
  • tests/application-starter-partners.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Server-side application-starter analysis now derives inferred partner IDs using selected partner IDs and compatible partners. A test covers selecting Clerk for a WorkOS authentication request.

Changes: Partner inference

Layer / File(s) Summary
Derive inferred partners and test selection
src/utils/application-starter.server.ts, tests/application-starter-partners.test.ts
Partner inference uses selected partner IDs with the compatible-partner set. The test verifies that selecting Clerk retains Clerk, infers no partners, and excludes WorkOS from the resulting recipe.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: abeuty

Merge Risk: ⚪ Minimal · up to 766b3

The partner inference change addresses the conflicting-selection case, with no concrete merge-blocking risk identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving explicitly selected partners during starter analysis.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 766b336 Commit Preview URL

Branch Preview URL
Oct 20 2026, 07:39 AM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant