Skip to content

Fix pyramid surface area validation messages - #7667

Open
adamsposato wants to merge 1 commit into
TheAlgorithms:masterfrom
adamsposato:new_branch
Open

adamsposato wants to merge 1 commit into
TheAlgorithms:masterfrom
adamsposato:new_branch

Conversation

@adamsposato

Copy link
Copy Markdown
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new algorithms include a corresponding test class that validates their functionality.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@@ -78,16 +79,15 @@ public static double surfaceAreaSphere(final double radius) {
*/
public static double surfaceAreaPyramid(final double sideLength, final double slantHeight) {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this method

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (a7a2441) to head (3432421).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/maths/Area.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7667   +/-   ##
=========================================
  Coverage     82.21%   82.22%           
  Complexity     8401     8401           
=========================================
  Files           843      843           
  Lines         26141    26141           
  Branches       5100     5100           
=========================================
+ Hits          21493    21494    +1     
+ Misses         3854     3853    -1     
  Partials        794      794           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants