Skip to content

Improve pyramid surface area validation and readability #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FarhanQ19 wants to merge 1 commit into from
Closed

Improve pyramid surface area validation and readability #7670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/main/java/com/thealgorithms/maths/Area.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,22 @@ public static double surfaceAreaSphere(final double radius) {
* @param slantHeight slant height of the pyramid
* @return surface area of the given pyramid
*/
public static double surfaceAreaPyramid(final double sideLength, final double slantHeight) {
public static double surfaceAreaPyramid(
final double sideLength, final double slantHeight) {

if (sideLength <= 0) {
throw new IllegalArgumentException("");
throw new IllegalArgumentException(
"side length must be greater than 0");
}

if (slantHeight <= 0) {
throw new IllegalArgumentException("slant height must be greater than 0");
throw new IllegalArgumentException(
"slant height must be greater than 0");

@FarhanQ19 FarhanQ19 Oct 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: The slant-height check rejects zero and negative values. Automated tests should verify that both cases throw IllegalArgumentException.

}
double baseArea = sideLength * sideLength;
double lateralSurfaceArea = 2 * sideLength * slantHeight;

final double baseArea = sideLength * sideLength;

@FarhanQ19 FarhanQ19 Oct 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: Declaring the calculation variables final makes it clear that they are not reassigned. The surface-area formula remains unchanged.

final double lateralSurfaceArea = 2 * sideLength * slantHeight;

return baseArea + lateralSurfaceArea;
}

Expand Down
Loading