Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
==========================================
+ Coverage 95.89% 95.91% +0.01%
==========================================
Files 396 397 +1
Lines 30441 30562 +121
==========================================
+ Hits 29192 29313 +121
Misses 1249 1249 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Added a test for the case where the midpoint is an exact root, covering the previously uncovered branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the bisection method for finding a root of a continuous function
inside a bracketing interval
[lower, upper](wheref(lower)andf(upper)have opposite signs).Option<f64>:Nonefor invalid input (non-finite bounds,non-positive or non-finite tolerance, NaN function values, no sign
change) or if the interval doesn't shrink below the tolerance within
max_iterationsF: Fn(f64) -> f64)Reference: https://en.wikipedia.org/wiki/Bisection_method
Type of change
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.