Skip to content

Social UI nits after #196 #197

Closed
Closed

Description

@Birfy

From the live resmoke on 0052df0 (A :3080, B :3081). Related: #173 (polish round 3), #182. Searched existing issues: none covers these.

  1. Past rooms list is stale. Right after leaving, or after a room closes, the room appears under Past rooms only after a page reload (A and B). FaceRooms polls social/face-rooms every 5 s, so this is more than lag; needs a live repro (the list may not be refreshed from the leave/close path).
  2. Composer under a read-only past room. The "You left this room." bar shows but the composer is still there. Hide it for read-only (left/closed) face rooms.
  3. + menu adds a "New… ×" tab to the main top bar while it is open.
  4. Account-menu handle is light grey (--bt-ink-2 at 12px): low contrast. Use the normal ink colour.
  5. "Friend's Bot" label (checked, not a section). There is no Friends' Bots heading in the sidebar. The text comes from the small marker's tooltip/aria-label (sidebar.js), the details drawer role line (details-drawer.js), and one error string in plugins/social/client.js ("That Bot is in Friends' Bots again") that names a section that no longer exists: reword it. Owner's rule (no separate section, only a small marker) is met.
  6. Chief greeting in Chinese with an English UI. The main-Bot kickoff in core/src/host/roster.js already says "Write in {uiLanguage}" and uiLanguage defaults to English until a browser reports a locale, so this is the model's own reply or a previously reported zh locale. Consider seeding the greeting language explicitly.

Activity

  1. added a commit that references this issue on Oct 17, 2026
  2. Birfy commented on Oct 17, 2026

    @Birfy
    CollaboratorAuthor

    Merged on main (35e1366): #211 covers items 2, 4 and 5.

    Covered (#211)

    • A left or closed face room hides the composer while the "You left this room." / "This room is closed." line shows.
    • Account-menu handle uses normal ink at 13px.
    • No text names a Friends' Bots section any more (relationship_exists message, held-message notice; the latter now names Auto-send, not Auto-accept).

    Still open

  3. Birfy commented on Oct 17, 2026

    @Birfy
    CollaboratorAuthor

    Self-test on 38c00b4: item 1 looks fixed (Past rooms updated without a reload after Leave, on both sides), and item 6 too (Chief's greeting in English on a fresh install). Item 3 is still there (+ opens a New… tab in the main pane).

  4. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Closing: everything here is done except item 3, and item 3 is the same thing #173 tracks, so it stays open there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions