Repository navigation
fix(chat): find RunningStatus under conversation.chat.flow on DSH 0.2.1 - #1628
Merged
Birfy merged 2 commits intoOct 29, 2026
Merged
Conversation
Fixes ThinkFlowLab#1626 On DSH 0.2.1 the shell RunningStatus host sits inside the conversation.chat.flow slot, so the activity row's direct-child RUNNING_HOST missed it. After send, CSS still hid the native whale and the Bot avatar + shimmer never portaled — empty / native-feeling chrome. Widen the host selector and findRunningHostIn for both 0.2.0 (direct) and 0.2.1+ (nested). BusyAckBubble reuses the same host constant. Written-by: Grok Bot (box-local; no Cursor CloudAgent)
The host-helper extract dropped the 1.5s friend-chat grace constant; oxlint failed CI with REMOTE_GRACE_MS is not defined. Written-by: Grok Bot
Collaborator
Author
|
Verdict: PASS at a889451 Ran at this tip: Not run:
FindingsNo actionable findings. Residual
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner: Danyang Chen
Reviewer: Reviewer
Written-by: Grok Bot (box-local; no Cursor CloudAgent)
Labels: agent-pr
Fixes #1626
Related: #1586 (busy-ack spoken bubble — merged; same host constant, still needs a found RunningStatus). #1624 (empty 「思考过程」 — claimed by FlyBot Lead; may share blank-while-working feel). #1509 (Steer/tool-wait interrupt — claimed by FlyBot Lead; not this PR). Do not conflate with Workflow #1619/#1618 UI.
What changed
On DSH 0.2.1-rc.2 (pinned in #1594 / v0.2.13),
RunningStatusmoved from a direct child of[data-chat-flow]into theconversation.chat.flowslot. FlyBot still used[data-chat-flow] > [data-chat-running], so after send:[data-chat-running]Fix:
RUNNING_HOST/findRunningHostInaccept both 0.2.0 (direct) and 0.2.1+ (nested under the flow slot). Helpers live inactivity-row-host.js(React-free).Verification at the tip
Tip SHA:
a88945155b72b4d816fb7cade04562daddf10c58Ran:
cd core && node --import ./test/harness-resolve.mjs --test test/activity-row-host.test.js test/friend-chat-awaiting.test.js test/busy-ack-client.test.js test/busy-ack.test.js test/client-bundle.test.js→ 19 pass / 0 failnode scripts/ds-bot-patches.mjs check→ oknode .github/scripts/changelog.mjs check→ well formedARCH_DOCS_BASE=origin/main npm run arch-docs --prefix core→ OKNot run: full
npm run verify/ LIVE/prod upgrade (out of scope).Residual
Gate (when CI green)
Birfy PASS + Attestation at tip; enqueue via merge queue (same as #1586). Do not force-merge.
Checkpoint
{ "pr": 1628, "claim": "Danyang Chen", "issue": 1626, "summary": "Activity row finds RunningStatus under conversation.chat.flow on DSH 0.2.1 so Bot avatar + shimmer return after send.", "files": [ "core/src/client/activity-row-host.js", "core/src/client/activity-row.js", "core/test/activity-row-host.test.js", "core/client.js", "docs/subsystems/core-client.md", "changelog.d/1626-activity-row-running-host.fixed.md", "patches/ds-bot/0003-flybot-api-client.patch", "patches/ds-bot/0007-version-and-tooling.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/src/client/activity-row-host.js", "patches/ds-bot/files/test/activity-row-host.test.js" ], "checks": { "ran": "activity-row-host + friend-chat-awaiting + busy-ack + client-bundle unit tests; ds-bot-patches check; changelog check; arch-docs", "result": "green", "at": "a88945155b72b4d816fb7cade04562daddf10c58" }, "next": "PASS + Attestation at tip when CI green; enqueue if gate allows — do not merge without owner" }