Repository navigation
Track requester-controlled task input waits - #212
Merged
Merged
Conversation
4 of 27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207. Refs #198 and #55.
Add requester-only
task-wait-input/task-answer-inputbookkeeping: a working task records one bounded selected question with a host-generated ID; only an answer to the current question can restore working status. Persist the latest question/answer snapshot and actor trail without copying chat history or prompting an agent.Keep approval and input waits independent. Explicitly task-tagged sends held during an input wait retain every approval ID, including across restart. The Bot owner decides approvals; the task requester answers the question. Neither action substitutes for the other. Restrict
task-startto claimed work so it cannot bypass a blocked input/approval state. Rejection, cancellation and Bot deletion preserve terminal outcomes.Seven channel regressions cover identity, invalid/stale input, restart, concurrent questions/answers, multiple holds and distinct requester/Bot-owner authority. Two new real-DSH mock-smoke steps verify that recording and answering input make zero model calls. Update docs, changelog and generated patches. Independent of #201/#203.
Verification at
7ab9c0dd690604ebe46742423eba1ffb0bb00663:TZ=UTC DSH_HARNESS=/workspace/FlyBot/core/dev/harness npm run verify: pass, 1,029 tests, 0 failed/skipped.ds-bot-patches.mjs checkverifies byte-exact reconstruction.task-startstill allowed blocked work, then passed after the guard.dsh-v0.2.0-rc.2(639ed015397290b3745d163aafe02ffee4aa3f84). Both new task-input steps report zero model calls. Both bench processes stopped.No automatic clarification delivery, adapter credential, remote execution authority or team-mode gate is added.
Author-run smoke evidence and reproduction
From
core/with a built checkout of the pinned DSH tag: