Repository navigation
Pin the phase-1 clarification and supervised-child contracts - #327
Merged
Merged
Conversation
The OpenCode adapter (P1) needs both seams fixed before code: a machine-checked blocking-question encoding (prose creates no wait) and the start/supervision/stop/restart-reconciliation/budget rules for the driver-owned child process. Both sections are pinned v1 design, not implementation. Fixes #326
Birfy
approved these changes
Oct 18, 2026
Birfy
left a comment
Birfy
left a comment
Collaborator
There was a problem hiding this comment.
PASS at tip ec5c956 (T0, docs-only). The clarification contract (structured flybot-question, host-only waits, answers never widen permissions) and the supervised-child lifecycle (persisted mapping before dispatch, owned teardown, restart reconciliation, host-side budgets) match the settled #198 phase-1 decisions and don't touch the #317 paragraphs. Enqueuing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326. Refs #198 (P1 prep: the two seams called out in the issue discussion as needing a contract before adapter code).
Docs-only, adds two pinned v1 sections to
docs/interop/room-participants.md, both explicitly marked not-yet-implemented:reply/working/question;questionrequires a structuredflybot-questionblock (validatedtaskId/turnId/text), malformed content degrades to a plain reply instead of creating a wait; only the host mintstask-wait-input; answers are untrusted data and never widen permissions. DSH already satisfies this via its exchange/waiter machinery — the section states what an OpenCode adapter must provide at the same seam.roomId+botId+taskId → (pid, session)mapping before first dispatch, owns teardown on round withdrawal / task cancel / member removal / room close / plugin unload (TERM→bounded wait→KILL, disposal recorded as requested/observed/uncertain), reconciles against the process table and runtime history after host restarts (orphans stopped, unconfirmable sessions uncertain with dispatch suppressed), and keeps budget counters host-side so a child restart resets nothing.Deliberately does not touch the paragraph PR #317 reworks, so both merge independently.
What I ran at tip: full
TZ=UTC npm run verify— green except the 3 known macOS-only room-collaboration failures fixed by #315 (docs-only change; CI Linux unaffected). What I did not run: nothing applicable beyond verify (no code changed).