Skip to content

Subgraph lists shutdown candidates once each #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Subgraph lists shutdown candidates once each #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions timely/src/progress/subgraph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ where
activations,
temp_active: BinaryHeap::new(),
maybe_shutdown: Vec::new(),
maybe_shutdown_listed: vec![false; children.len()],
children,
input_messages: self.input_messages,
output_capabilities: vec![MutableAntichain::new(); self.outputs],
Expand Down Expand Up @@ -254,6 +255,8 @@ where
activations: Rc<RefCell<Activations>>,
temp_active: BinaryHeap<Reverse<usize>>,
maybe_shutdown: Vec<usize>,
// whether each child is in `maybe_shutdown`.
maybe_shutdown_listed: Vec<bool>,

// shared state written to by the datapath, counting records entering this subgraph instance.
input_messages: Vec<Rc<RefCell<ChangeBatch<TInner>>>>,
Expand Down Expand Up @@ -476,7 +479,10 @@ where
// Drain propagated information into shared progress structure.
let (pushed, operators) = self.pointstamp_tracker.pushed();
for ((location, time), diff) in pushed.drain() {
self.maybe_shutdown.push(location.node);
if !self.maybe_shutdown_listed[location.node] {
self.maybe_shutdown_listed[location.node] = true;
self.maybe_shutdown.push(location.node);
}
// Targets are actionable, sources are not.
if let crate::progress::Port::Target(port) = location.port {
// Activate based on expressed frontier interest for this input.
Expand All @@ -497,9 +503,8 @@ where
}

// Consider scheduling each recipient of progress information to shut down.
self.maybe_shutdown.sort_unstable();
self.maybe_shutdown.dedup();
for child_index in self.maybe_shutdown.drain(..) {
self.maybe_shutdown_listed[child_index] = false;
let child_state = self.pointstamp_tracker.node_state(child_index);
let frontiers_empty = child_state.targets.iter().all(|x| x.implications.is_empty());
let no_capabilities = child_state.cap_counts == 0;
Expand Down