Repository navigation
Conversation
ExtremeTests were calling prepareToPlay and releaseResources directly on the VST3 instances, which is not allowed by the VST3 spec. Use the call[...]OnMessageThreadIfVST3 helpers like the rest of the tests do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prepare/release calls in
ExtremeTests.cppweren't using thecallPrepareToPlayOnMainThreadIfVST3-helpers like the rest of the tests.I had a dead simple synth plugin mysteriously fail the subnormals test and adding this fixed it.