Skip to content

Fix table indices in Memory64Lowering - #9275

Open
Sree24-ui wants to merge 1 commit into
WebAssembly:mainfrom
Sree24-ui:fix/memory64-lowering-table-get-set
Open

Sree24-ui wants to merge 1 commit into
WebAssembly:mainfrom
Sree24-ui:fix/memory64-lowering-table-get-set

Conversation

@Sree24-ui

Copy link
Copy Markdown

Summary
Handle table.get and table.set indices in Memory64Lowering, wrapping 64-bit table indices when lowering the table address type.
Add regression coverage for constant, dynamic, and nested indices, as well as 32-bit table operations.
Testing

  • git diff --check passed.
  • The focused lit test was attempted, but could not complete because filecheck is unavailable in the local environment.
    AI assistance was used during development and review.

@Sree24-ui
Sree24-ui requested a review from a team as a code owner October 18, 2026 18:21
@Sree24-ui
Sree24-ui requested review from stevenfontanella and removed request for a team October 18, 2026 18:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements memory64 lowering for table.get and table.set instructions by adding visitTableGet and visitTableSet methods to the Memory64Lowering pass, which wrap the table index using wrapTableAddress64. It also adds comprehensive lit tests to verify the correct wrapping behavior for 64-bit tables and ensure 32-bit tables remain unaffected. There are no review comments to evaluate, and the implementation appears correct.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant