Repository navigation
Conversation
Sree24-ui
requested review from
stevenfontanella
and removed request for
a team
October 18, 2026 18:21
There was a problem hiding this comment.
Code Review
This pull request implements memory64 lowering for table.get and table.set instructions by adding visitTableGet and visitTableSet methods to the Memory64Lowering pass, which wrap the table index using wrapTableAddress64. It also adds comprehensive lit tests to verify the correct wrapping behavior for 64-bit tables and ensure 32-bit tables remain unaffected. There are no review comments to evaluate, and the implementation appears correct.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle table.get and table.set indices in Memory64Lowering, wrapping 64-bit table indices when lowering the table address type.
Add regression coverage for constant, dynamic, and nested indices, as well as 32-bit table operations.
Testing
AI assistance was used during development and review.