Skip to content

Tests: Make data providers in tests/phpunit/tests/secrets/ public and static - #14670

Open
rvpatel wants to merge 1 commit into
WordPress:trunkfrom
rvpatel:66211-secrets-data-providers-static
Open

rvpatel wants to merge 1 commit into
WordPress:trunkfrom
rvpatel:66211-secrets-data-providers-static

Conversation

@rvpatel

@rvpatel rvpatel commented Oct 21, 2026

Copy link
Copy Markdown

Makes the 14 data providers in tests/phpunit/tests/secrets/ static. PHPUnit 10 deprecates data providers that are not public and static, and PHPUnit 11 removes support for them.

None of these providers use $this, so only the static keyword is added. Seven files change, with one word per provider.

Trac ticket: https://core.trac.wordpress.org/ticket/66211

Testing Instructions

Run each changed file, on single site and multisite:

npm run test:php -- tests/phpunit/tests/secrets/

All tests pass. The skipped tests in wpSecretsConfigKeyProvider.php and wpSecretsKeyManager.php depend on the environment, and are skipped the same way on trunk.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Used for: Finding the providers, making the change and running the tests. I reviewed the diff.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

PHPUnit 10 deprecates data providers that are not public and static, and PHPUnit 11 removes support for them. None of these providers use `$this`, so only the `static` keyword is added.

See #66211.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ravipatel.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good to me, and CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants