Skip to content

feat: link merkl tooltip learn more to merkl campaign page - #3146

Merged
sammdec merged 1 commit into
mainfrom
feat/merkl-tooltip-campaign-link
Oct 21, 2026
Merged

sammdec merged 1 commit into
mainfrom
feat/merkl-tooltip-campaign-link

Conversation

@sammdec

@sammdec sammdec commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The "Learn more" link in the Merkl incentives tooltip now opens the Merkl opportunity page for that campaign (https://app.merkl.xyz/opportunities/<id>). Before, it always went to the ACI emission manager governance post.
  • useMerklIncentives returns a new merklOpportunityUrl built from the primary opportunity's id.
  • Link order: customForumLink from config (if set), then the Merkl opportunity URL, then the ACI governance post as a last resort.
  • Deduplicated the two identical href expressions into a single learnMoreLink.

Test plan

  • Hover a reserve with a Merkl incentive and click "Learn more": it opens that campaign's Merkl page
  • Reserves with a customForumLink configured (e.g. the Ethena entry) still link to their custom URL

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.34 MB (-3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 93.54 KB (🟡 +32 B) 1.43 MB
/dashboard 82.2 KB (🟡 +32 B) 1.42 MB
/markets 54.7 KB (🟡 +32 B) 1.39 MB
/safety-module 55.71 KB (🟡 +32 B) 1.39 MB
/sgho 92.81 KB (🟡 +32 B) 1.43 MB
/v3-migration 49.11 KB (🟡 +32 B) 1.39 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Oct 21, 2026 3:42pm UTC

Request Review

@sammdec
sammdec merged commit 9f539a3 into main Oct 21, 2026
15 of 22 checks passed
@sammdec
sammdec deleted the feat/merkl-tooltip-campaign-link branch October 21, 2026 15:50

This branch was successfully deployed

1 active deployment
Preview — 71798584 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants