Repository navigation
turbo mpy import fix for p4 - #11681
Merged
Merged
Conversation
Collaborator
|
Looks safe. ESP32-P4 only effected. Just running a test on my side to see if anything comes up. |
mikeysklar
reviewed
Oct 28, 2026
if instead of ifdef Co-authored-by: Mikey Sklar <mikeysklar@gmail.com>
if instead of ifdef Co-authored-by: Mikey Sklar <mikeysklar@gmail.com>
if instead of ifdef Co-authored-by: Mikey Sklar <mikeysklar@gmail.com>
Collaborator
Author
|
Thank you! suggested changes are brought in with the latest commits. |
Collaborator
|
Retested latest commit on the P4 GPIO. Looking good. Thank you @FoamyGuy |
mikeysklar
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing compiled turbo .mpy files on the Metro P4 is causing a hard fault.
This change fixes it and allows the modules to be imported and used successfully.