Repository navigation
Conversation
2.1.2 types the send() and sendRaw() results (TSentMessageInfo instead of any) and uses the types nodemailer 10 ships. The lockfile drops the old @types/nodemailer packages it pulled in. No code changes here: Email.ts and Person.ts pass the result through unchanged. Verified on the host: check, check:types, Node 9/9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the example to framework-module-email 2.1.2 (release notes).
ce4399b):@adaptivestone/framework-module-email^2.1.2. In 2.1.2 thesend()andsendRaw()results are typed (TSentMessageInfoinstead ofany), using the types nodemailer 10 ships. The lockfile drops the old@types/nodemailerpackages the module used to pull in.src/controllers/Email.tsreturns thesend()result as JSON andsrc/models/Person.tsreturns it fromsendCreatEmail, and both type-check with the new type.Verification (on the host, not in Docker)
npm run check,npm run check:types(gen + tsc): cleannpm test: 9/9GET /email/:emailsend through Mailpit, because the Docker stack was not runningnpm audit: 1 low (deepmerge, GHSA-gcqx-w48m-w2h4), which comes through the email module and is not new in 2.1.2