Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #703.
Recognize SQL Server's
TOPas a keyword, including parenthesized row limits, so keyword case formatting handles it consistently.Preserve qualified names such as
schema. top(1)across whitespace and comments. The lexer tracks whether the preceding significant token was a dot instead of rescanning the input prefix.Tests cover case variations, row-limit parentheses and whitespace, quoted identifiers, and qualified columns and functions. Twelve TOP regressions fail on master. With the fix, all 37 focused cases pass and the full suite reports 543 passed, 2 xfailed and 1 xpassed (the existing xfail/xpass results are unchanged).
Validated on Python 3.11.5/macOS; Ruff and
git diff --checkpass.