Repository navigation
test .zip archives - #513
Merged
Merged
Conversation
rjbs
marked this pull request as draft
May 12, 2024 01:27
rjbs
force-pushed
the
archive-zip-tests
branch
3 times, most recently
from
October 24, 2026 16:17
cdf6154 to
c48387a
Compare
rjbs
marked this pull request as ready for review
October 24, 2026 16:19
Upload the simplest possible dist as both a tarball and a zip file, and check that each is indexed the same way. This needed Module::Faker 0.027, which chmods the files it puts in a zip archive to 0644; before that, Archive::Any::Create made them world writable and PAUSE rejected the upload.
p6_index_dist lists the archive with tar to find bin/ entries. For a zip archive that fails, and the failure aborts indexing the whole dist. Pick the listing command by file extension; "unzip -Z1" prints one entry name per line, the same shape as "tar tf". Co-Authored-By: Claude <noreply@anthropic.com>
untar sets PERL_MAJOR_VERSION while listing the tarball, but the zip branch of examine_dist never set it, so perl_major_version was undef for every zip upload. That meant "uninitialized value" warnings on each comparison and, for an actual Perl 6 dist in a zip, indexing it as a Perl 5 dist with no META file. After unzipping, look for a top-level-directory META6.json, the same test untar applies to the listing. Co-Authored-By: Claude <noreply@anthropic.com>
corpus/mld/perl6-zip holds the same Inline-1.1 dist as corpus/mld/perl6, repacked as a zip file, and the Perl 6 indexing test now runs over both. Co-Authored-By: Claude <noreply@anthropic.com>
Each insert pushed (errstr, ret) onto @Args but logged the first as "ret" and the second as "err", so a successful insert was logged as ret "" and err 1. Push them in the order the log reads them. Co-Authored-By: Claude <noreply@anthropic.com>
rjbs
force-pushed
the
archive-zip-tests
branch
from
October 28, 2026 14:05
c48387a to
dfe3964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocked by a new Module-Faker, which is kinda waiting on miyagawa/Archive-Any-Create#3
Also, this is really just one commit on top of #510
Also, this exposes that
->untarsetsPERL_MAJOR_VERSIONbut zip archives never have it set. Other discrepancies may show up, too.