Repository navigation
PAUSE::pmfile: accept a $VERSION assignment inside a one-line BEGIN - #600
Merged
Merged
Conversation
rspier
approved these changes
Oct 26, 2026
There's no good reason anymore to reject:
BEGIN { our $VERSION = '1.0' }
…given we accept the version without BEGIN. It's statically simple.
The old eval-based code got undef for these lines, because the BEGIN
block ran while its wrapper was being compiled, before the wrapper
cleared $VERSION. Now they get their real version. In the minicpan
corpus, this affects 19 files in 6 dists.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no good reason anymore to reject:
…given we accept the version without BEGIN. It's statically simple.
The old eval-based code got undef for these lines, because the BEGIN block ran while its wrapper was being compiled, before the wrapper cleared $VERSION. Now they get their real version. In the minicpan corpus, this affects 19 files in 6 dists.