Repository navigation
ci: run sync-info only on dev and keep i18n order stable - #332
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sync Plugin Info workflow ran on pushes to both
devandmainwhile always using the samechore/sync-infobranch. Adevrun force-pushed that branch ontodev, so themainsync PR (#330) suddenly showed the whole LDAP connector, and two bot PRs (#330, #331) shared one branch. Separately,sync-info.shiterated i18n files in unsortedfindorder, sozh_CN/en_UScould swap between runs and produce large reorder-only diffs.Changes:
dev(changes reachmainvia dev); setbase: devexplicitly anddelete-branch: true.concurrencygroup so back-to-back pushes don't race on the branch.LC_ALL=C sortso key order is deterministic (en_US, thenzh_CN, matching the current file).Tested locally on
dev: the regeneratedplugins_desc.jsononly adds the new LDAP and vector-search entries (+65/−0), with no reordering, and two runs are byte-identical.