Skip to content

GH-54689: [Ruby] Keep TableBatchReader source table alive #55245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikamikasuki wants to merge 1 commit into from
Closed

GH-54689: [Ruby] Keep TableBatchReader source table alive #55245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c_glib/arrow-glib/reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ GArrowTableBatchReader *
garrow_table_batch_reader_new(GArrowTable *table)
{
auto arrow_table = garrow_table_get_raw(table);
auto arrow_table_batch_reader = std::make_shared<arrow::TableBatchReader>(*arrow_table);
auto arrow_table_batch_reader = std::make_shared<arrow::TableBatchReader>(arrow_table);
return garrow_table_batch_reader_new_raw(&arrow_table_batch_reader, table);
}

Expand Down
10 changes: 10 additions & 0 deletions ruby/red-arrow/test/test-record-batch-reader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,14 @@ class TestRecordBatchReader < Test::Unit::TestCase
reader.read_all)
end
end

test("exported TableBatchReader keeps its table alive") do
expected = Arrow::Table.new("count" => [1, 2, 3])
stream =
Arrow::TableBatchReader.new(Arrow::Table.new("count" => [1, 2, 3])).export
GC.start

reader = Arrow::RecordBatchReader.import(stream)
assert_equal(expected, reader.read_all)
end
end
Loading