UI: allow memory setting in flex compute offering in GiB with unit selector (#14082) by saurabhkushwaha438 · Pull Request #14413 · apache/cloudstack

saurabhkushwaha438 · 2026-10-16T05:08:51Z

Description

Fixes #14082

1. Conversion from MiB to GiB (Display & Rounding)

Binary conversion is used (1 GiB = 1024 MiB).
When offerings with predefined constraints or initial values are loaded in MiB, or when switching from MiB to GiB:
$$\text{displayValue} = \text{parseFloat}\left(\left(\frac{\text{rawMemory}}{1024}\right)\text{.toFixed(2)}\right)$$
The display value is rounded to 2 decimal places to keep the UI clean, readable, and intuitive for users.
Slider step dynamically adjusts:
- In GiB mode: step is set to 0.01 (or smaller for sub-GiB offerings) with precision 2.
- In MiB mode: step is set to 1 with integer precision 0.

2. Conversion from GiB to MiB (Backend Value Emission)

CloudStack APIs and backend services expect memory allocations in integer MiB.
When the user selects or inputs memory in GiB:
$$\text{memoryInMiB} = \text{Math.round}(\text{displayValue} \times 1024)$$
Exact Boundary Protection: If a compute offering has minimum/maximum memory constraints (minMemory / maxMemory), selecting the exact minimum or maximum bound in GiB directly maps to the exact integer minMemory or maxMemory in MiB to eliminate any potential off-by-one rounding discrepancies.

💬 Feedback Needed: Fractional GiB to Integer MiB Rounding

Observation: Converting decimal GiB values to MiB often produces fractional values (e.g., 1.51 GiB × 1024 = 1546.24 MiB).
Current Behavior: The UI rounds this to the nearest integer (1546 MiB), which is then emitted in the API payload and consumed by backend hypervisor managers.
Reviewer Input: Looking for maintainer feedback on whether standard nearest-integer rounding (Math.round) is acceptable, or if we should apply ceiling (Math.ceil) to guarantee the VM always receives at least the requested GiB amount.

bandicam.2026-10-16.10-21-12-210.mp4

Damans227 · 2026-10-16T13:57:08Z

      this.updateComputeCpuNumber(this.preFillContent.cpunumber || this.cpuNumberInputValue)
      this.updateComputeCpuSpeed(this.preFillContent.cpuspeed || this.cpuSpeedInputValue)
-      this.updateComputeMemory(this.preFillContent.memory || this.memoryInputValue)
+      this.updateComputeMemory(this.memoryDisplayValue)


what happens when the memory isnt a round GiB value? an imported vm with 1500 MB shows as 1.46 GiB and gets sent back as 1495 without the user touching it

nice catch , now i am confuse and would be great to get suggestion from you and others

np. maybe, we can open it in MiB when the value isnt a whole number of GiB? then 1500 stays 1500. on load and on a unit switch, send the saved MiB value as is and only convert when the user changes the number.

another option could be use GIB for display only because MIB is only state and single source of truth so in backend we will use actual MIB value

that only works if the saved MiB is what gets sent.

bandicam.2026-10-17.21-08-51-749.mp4

how about this , is this better direction

@saurabhkushwaha438 This looks better. But IMHO I think that having a slider for GiB that goes in increments of 0.01 is not a very interesting design. I think both the GiB and MiB increments should be of 1 (of their respective unit of mesurement).
If you want to have a VM with 1.6 GiB for some reason, you can just use the MiB slider. I believe most users will use whole GiB numbers, not fractions.

ok i will this "GiB and MiB increments should be of 1"

bandicam.2026-10-17.21-08-51-749.mp4
how about this , is this better direction

and i havent commited those change yet

@saurabhkushwaha438 yes this is a better direction, 1500 stays 1500 now unless the user changes it. any reason for 0.25 GiB steps? you agreed with joao on steps of 1 for GiB and MiB.

codecov · 2026-10-29T16:39:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.87%. Comparing base (7ed0cec) to head (c401af2).
⚠️ Report is 82 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (7ed0cec) and HEAD (c401af2). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (7ed0cec) HEAD (c401af2)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #14413       +/-   ##
=============================================
- Coverage     19.91%    3.87%   -16.04%     
=============================================
  Files          6373      493     -5880     
  Lines        577230    42613   -534617     
  Branches      70696     8087    -62609     
=============================================
- Hits         114936     1653   -113283     
+ Misses       449736    40729   -409007     
+ Partials      12558      231    -12327

Flag	Coverage Δ
uitests	`3.87% <ø> (+0.16%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nvazquez · 2026-10-30T01:33:52Z

@blueorangutan ui

blueorangutan · 2026-10-30T01:35:04Z

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-10-30T01:56:51Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14413 (QA-JID-1003)

…B step (apache#14082) - Add compact unit selector dropdown (GiB/MiB) for flex compute offerings - Use fixed 0.25 GiB steps in GiB mode (binary-exact to 256 MiB intervals, zero rounding errors) - Maintain integer MiB as authoritative internal state to prevent lossy conversion on load - Default to GiB for 256 MiB multiples and MiB for arbitrary sizes (e.g. 1500 MiB) - Add hover tooltip to display exact converted values

Damans227 · 2026-10-30T17:10:46Z

+    updateComputeMemory (displayValue) {
+      if (displayValue === null || displayValue === undefined) {
+        this.memoryDisplayValue = 0
+        displayValue = 0


@saurabhkushwaha438 can we keep the required error when the box is cleared? on an offering with no limits this now sends 0 instead.

Damans227 · 2026-10-30T17:10:47Z

@blueorangutan ui

blueorangutan · 2026-10-30T17:12:05Z

@Damans227 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

boring-cyborg Bot added the component:UI label Oct 16, 2026

Damans227 reviewed Oct 16, 2026

View reviewed changes

nvazquez added this to the 24.0 milestone Oct 30, 2026

nvazquez mentioned this pull request Oct 30, 2026

UI: Please change memory setting in flex compute offering from MiB to GiB #14082

Open

saurabhkushwaha438 force-pushed the issue-14082-flex-memory-gib branch from db7c8a0 to 2c7e3a6 Compare October 30, 2026 06:33

saurabhkushwaha438 force-pushed the issue-14082-flex-memory-gib branch from 2c7e3a6 to c401af2 Compare October 30, 2026 06:42

Damans227 reviewed Oct 30, 2026

View reviewed changes

Conversation

saurabhkushwaha438 commented Oct 16, 2026

Description

1. Conversion from MiB to GiB (Display & Rounding)

2. Conversion from GiB to MiB (Backend Value Emission)

💬 Feedback Needed: Fractional GiB to Integer MiB Rounding

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nvazquez commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Damans227 commented Oct 30, 2026

Uh oh!

blueorangutan commented Oct 30, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Oct 29, 2026 •

edited

Loading