Repository navigation
Conversation
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9564 +/- ##
=========================================
Coverage 20.66% 20.67%
- Complexity 21720 21735 +15
=========================================
Files 6492 6492
Lines 590728 590735 +7
Branches 72448 72451 +3
=========================================
+ Hits 122101 122143 +42
+ Misses 455355 455315 -40
- Partials 13272 13277 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10733 |
| true, ConfigKey.Scope.Zone); | ||
| ConfigKey<String> PreferredStoragePool = new ConfigKey<String>(String.class, "preferred.storage.pool", "Advanced", "", | ||
| "The UUID of preferred storage pool for allocation.", true, ConfigKey.Scope.Account, null); | ||
| ConfigKey<String> PreferredStoragePool = new ConfigKey<>(String.class, "preferred.storage.pool", "Advanced", "", |
There was a problem hiding this comment.
I wonder if we can have two configurations with same key
- 1 for global/zone/cluster
- 2 for global/domain/account
changing from Account to Cluster may be disliked by some users (maybe)
There was a problem hiding this comment.
Thanks @weizhouapache - there is now an option to define multiple scopes per setting: https://docs.cloudstack.apache.org/en/4.22.0.0/installguide/configuration.html#granular-global-configuration-parameters. I will explore this
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11126)
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@nvazquez should this target 4.19? |
|
@DaanHoogland the issue this PR fixes was on the 4.19.2 milestone but I think it shouldn't be there as 4.20.0 is already out and changing the scope of the setting would be conflicting, perhaps it should be targeted to 4.20 instead of main? |
|
@nvazquez we can change to v21 as well as it is an enhancement...? |
|
Sure @DaanHoogland fixed |
|
@nvazquez |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
moved this from Backlog
to conflict/waiting for author
in CloudStack Testing
nvazquez
changed the title
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19783 |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
This PR changes the
preferred.storage.poolsetting scope from Account to Account and Cluster scope.The Account value takes precedence over the Cluster value, which takes precedence over the Global value.
Fixes: #8959
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?