Repository navigation
Conversation
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GithubAppKey.CreateJwtsetiat = nowandexp = now + 600. GitHub rejects a JWT whoseexpis more than 10 minutes in the future, so a host clock even 1s ahead of GitHub's made installation token requests fail with 401 ("'Expiration time' claim ('exp') is too far in the future").This follows GitHub's recommendation:
iatis backdated by 60s andexpis set tonow + 540, so the token lifetime stays at 10 minutes. Added a unit test that checks both bounds.GitHub docs: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app
Does this close any open issues?
Part of #9220 (the JWT part only; the silent cron failure and the 401 passthrough are left for separate PRs).