Repository navigation
[Subscription] Resume realtime delivery after WAL gap recovery - #18912
Merged
jt2594838 merged 1 commit intoOct 19, 2026
Merged
Conversation
jt2594838
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a transient realtime admission failure, subscription WAL gap recovery can replay requests that have already been admitted into the pending queue. For example, rejecting index 1 and then admitting indexes 2–8 causes all eight requests to be delivered through WAL, while their pending copies are discarded as duplicates. This prevents the recovered realtime path from supplying those requests.
Stop gap replay at the next pending index and resume direct pending delivery. If a sparse WAL jumps to or past that boundary, retain its buffered request and report only the missing prefix. Replicated requests without local search indexes before the boundary are still replayed. Existing scan budgets, memory limits, ordering, and commit handling continue to apply.
Validation
mvn -nsu test -Dtest=ConsensusPrefetchingQueue*Test,ProgressWALIteratorTest -Dsurefire.failIfNoSpecifiedTests=false -Ddevelocity.off=truesucceeds across all 53 modules; 111 tests pass and one opt-in performance test is skipped.mvn -nsu test-compile -Pwith-zh-locale -DskipTests -Ddevelocity.off=truesucceeds across all 53 modules.mvn spotless:apply -pl iotdb-core/datanodeandgit diff --checkpass.The original pressure workload has not been rerun in a cluster.
This PR has: