Repository navigation
ORC-2225: [C++] Use narrowed FLOAT value for statistics - #2726
Closed
dajiaohuang wants to merge 2 commits into
Closed
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
Align encoded FLOAT values with their statistics and Bloom filter entries. Add a predicate pushdown regression for the stored binary32 value. Generated-by: OpenAI Codex gpt-6-luna
ffacs
changed the title
ffacs
approved these changes
Oct 27, 2026
wgtmac
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For FLOAT columns, use the binary32 value represented by the serialized data when updating stripe statistics and Bloom filters. Keep DOUBLE behavior unchanged. Add a predicate-pushdown regression that searches for the stored FLOAT value after writing a value that rounds during binary32 conversion.
Why are the changes needed?
ORC-2225 reports that C++ FLOAT statistics can reflect the pre-narrowed double instead of the value serialized as FLOAT. Using the stored value consistently prevents statistics and Bloom filters from describing a different value than the encoded data.
How was this patch tested?
orc-testtarget with the task-local Visual Studio 2026 CMake/Ninja/MSVC configuration.orc-test.exe --gtest_filter="*testFloatPredicateUsesStoredValue*"— 1/1 passed.orc-test.exe --gtest_filter="TestPredicatePushdown.*"— 5/5 passed.-R "^orc-test$" --output-on-failurecompleted successfully.git diff --checkpassed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex gpt-6-luna