Repository navigation
Conversation
Since the quickstart archetype is tested during the build, its pom runs maven-invoker-plugin:install to give the generated project the Wicket modules it needs. Without a localRepositoryPath that goal installs into the user's own local repository, so a plain mvn verify left 17 Wicket files in ~/.m2, marked as locally installed and therefore never re-downloaded. After verifying a release candidate those were jars with the final release version built from the RC, which a later RC reusing the version number would silently be shadowed by. invoker:install and archetype:integration-test now share a local repository at target/it-repo. The generated project resolves Wicket from there and fetches everything else through the user's normal settings, mirrors included. A clean build therefore downloads the integration test's third-party dependencies, about 56 MB, once more into target/it-repo. Nothing changes for applications; mvn verify no longer writes to ~/.m2. GitHub issue #1724 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1730 +/- ##
============================================
- Coverage 63.17% 63.17% -0.01%
+ Complexity 11558 11557 -1
============================================
Files 1253 1253
Lines 48635 48635
Branches 6844 6844
============================================
- Hits 30725 30724 -1
- Misses 15192 15193 +1
Partials 2718 2718 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1724
Since the quickstart archetype is tested during the build, its pom runs
maven-invoker-plugin:installto give the generated project the Wicket modules it needs. Without alocalRepositoryPaththat goal installs into the user's own local repository, so a plainmvn verifyleft 17 Wicket files in~/.m2, marked as locally installed and therefore never re-downloaded. After verifying a release candidate those were jars with the final release version built from the RC, which would silently shadow a later RC reusing the version number.invoker:installandarchetype:integration-testnow share a local repository attarget/it-repo, set through thearchetype.test.localRepositoryPathproperty. The generated project resolves Wicket from there and fetches everything else through the user's normal settings, mirrors included.The cost: a clean build downloads the integration test's third-party dependencies (about 56 MB, mostly Maven plugins) into
target/it-repoagain. Reading them from~/.m2instead would need a custom settings file for the integration test, which replaces the user's settings and so drops their mirrors and proxies.Nothing changes for applications.
Verified with
mvn clean verify -Pjs-test: green, and nothing new under~/.m2/repository/org/apache/wicketafterwards.This is on master only for now; the
wicket-10.xbackport follows separately.🤖 Generated with Claude Code