Repository navigation
Conversation
Every module carried an ApacheLicenceHeaderTest built on ApacheLicenseHeaderTestCase from wicket-util, each with its own ignore lists. The root build now checks license headers with Apache RAT over the whole source tree, the check the Apache Trusted Releases platform runs on a release, so these tests check a subset of the same thing a second time and their ignore lists have to be kept in step with .rat-excludes. The per-module tests are removed. ApacheLicenseHeaderTestCase is public API in wicket-util's main code, as is the ApacheLicenceHeaderTest that sits next to it, so both stay and are deprecated for removal instead. The tests also checked that HTML and XML files start with an XML prolog. That check goes with them; RAT does not replace it. An application that extends ApacheLicenseHeaderTestCase keeps working and gets a deprecation warning. Its replacement is Apache RAT in its own build; there is no mechanical migration, so no OpenRewrite recipe. Proposed migration guide text: "ApacheLicenseHeaderTestCase is deprecated for removal. Wicket checks its own license headers with Apache RAT; use apache-rat-plugin in your build instead." Merge after the change that adds Apache RAT to the build. GitHub issue #1723 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1733 +/- ##
============================================
- Coverage 63.17% 62.65% -0.53%
+ Complexity 11558 11490 -68
============================================
Files 1253 1254 +1
Lines 48635 48660 +25
Branches 6844 6844
============================================
- Hits 30725 30486 -239
- Misses 15192 15489 +297
+ Partials 2718 2685 -33 🚀 New features to boost your workflow:
|
papegaaij
marked this pull request as ready for review
October 31, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1723. Merge after #1732, which adds the RAT check that replaces these tests.
Every module carried an
ApacheLicenceHeaderTestbuilt onApacheLicenseHeaderTestCase, each with its own ignore lists. With RAT checking the whole tree, they check a subset of the same thing a second time, and their ignore lists would have to be kept in step with.rat-excludes.What changes
ApacheLicenceHeaderTestclasses are removed.ApacheLicenseHeaderTestCaseis deprecated for removal. It is public API in wicket-util's main code, as is theApacheLicenceHeaderTestnext to it, so both stay with@Deprecated(since = "10.12.0, 11.0.0", forRemoval = true).sinceneeds to move to the next version.Migration
Applications that extend
ApacheLicenseHeaderTestCasekeep working and get a deprecation warning. There is no mechanical migration, so there is no OpenRewrite recipe.Proposed migration guide text:
Verification
mvn clean verify -Pjs-testpasses.🤖 Generated with Claude Code