Repository navigation
Conversation
Wicket checked license headers only with its own ApacheLicenseHeaderTestCase, one test per module, each with its own ignore lists and each covering only its module's directory. Files outside the modules, the user guide, markdown, YAML, service files and anything outside the file types the test knows were never checked. Apache RAT, run over the source tree, reported 1470 files without an approved license. The Apache Trusted Releases platform runs RAT 0.18 on every source archive and reads its exclusions from a .rat-excludes file at the archive root. Unapproved files are recorded as concerns the release manager has to acknowledge before a vote can start. The root pom now runs apache-rat-plugin 0.18 over the whole tree at validate, reading the same .rat-excludes. Files that can carry a header now have one: the markdown files, .asf.yaml, the service files, the user guide, a few XML and text files and two Java files that lacked it. The exclusions record the files that stay without one and why: third-party code, which LICENSE covers, generated release notes, IDE settings, the archetype's project templates, markup rendered to the browser as is, example markup (as the examples' header test already decided) and test data that tests compare byte for byte. These follow the ignore lists of the existing header tests. Locally the check also skips what Git ignores, node and node_modules, and minified files. It takes about half a minute, so -Pfast skips it. A file without a header that is neither committed nor ignored by Git, such as a local note, now fails the build until it gets a header or is removed. GitHub issue #1723 (cherry picked from commit 3569543, with headers added to the files as they are on wicket-10.x) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
papegaaij
marked this pull request as ready for review
October 31, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1732 to
wicket-10.x, for #1723. See #1732 for the reasoning.Difference from master
AGENTS.md,CLAUDE.md,JAVASCRIPTTESTING.md,migration-to-11.mdand the benchmarks README don't exist there..adocfiles.pom.xmlthe RAT plugin is added next to 10.x's own plugin versions..rat-excludesis identical to master's.Verification
mvn clean verify -Pjs-testpasses, and RAT reports no issues.git archivereports 0 unapproved files. Dojo is the only non-Apache license it detects, as on master.🤖 Generated with Claude Code