Repository navigation
fix(event_handler): leave SameSite out of cookies in DEFAULT_MODE - #8709
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
powertools-for-aws-oss-automation
Bot
added
the
size/S
|
leandrodamascena
approved these changes
Oct 31, 2026
leandrodamascena
left a comment
leandrodamascena
left a comment
Contributor
There was a problem hiding this comment.
Thanks @anishmehta24, confirmed through both the REST and HTTP API resolvers: DEFAULT_MODE now leaves SameSite out, Lax/Strict/None and cookies without same_site are unchanged.
I'm approving now. This goes out in 3.40.0, so it will sit here for a while before I merge it. No rebase needed in the meantime, and you'll be credited in the release notes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8708
Summary
Changes
Cookie.__str__wroteSameSite={value}for anysame_siteenum member, andSameSite.DEFAULT_MODEhas the value"", so a cookie in default mode was sent withSameSite=. The attribute is now only written when the value is not empty, which leaves it out forDEFAULT_MODElike Go'shttp.SameSiteDefaultMode.Added
test_cookie_with_same_site_default_modeintests/unit/test_cookie_class.py; it fails ondevelop. The cookie unit tests and the event handler cookie tests pass.User experience
Before:
str(Cookie("session", "abc", same_site=SameSite.DEFAULT_MODE))issession=abc; Secure; SameSite=. After:session=abc; Secure.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.