Repository navigation
fix(data_classes): return None from TransferFamilyAuthorizer.password when the event has none - #8715
Open
anishmehta24 wants to merge 1 commit into
Conversation
… when the event has none
|
leandrodamascena
approved these changes
Oct 31, 2026
leandrodamascena
left a comment
Contributor
There was a problem hiding this comment.
Thanks @anishmehta24, confirmed. Transfer Family only sends password for password logins, the AWS sample identity provider itself checks for the missing key, and our Pydantic model already defaults it to None, so the data class was the odd one out.
I'm approving now. This goes out in 3.40.0, so it will sit here for a while before I merge it. No rebase needed in the meantime, and you'll be credited in the release notes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8714
Summary
Changes
TransferFamilyAuthorizer.passwordis typedstr | Noneand documented asNonefor non-password logins, but indexed the event directly, so an event withoutpasswordraisedKeyError. It now returnsself.get("password"), matching the Pydantic model, which already defaultspasswordtoNone. The docstring now says it'sNonewhen the event has no password (e.g. SSH key login) rather than mentioning certificates.Added
test_transfer_family_authorizer_event_without_passwordintests/unit/data_classes/required_dependencies/test_transfer_family_event.py; it fails ondevelopwithKeyError: 'password'.User experience
Before:
TransferFamilyAuthorizer(event).passwordraisesKeyErrorwhen the event has no password. After: it returnsNone.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.