Repository navigation
Add ReplayName to CloudWatchEvent - #652
Open
alessandrolattao wants to merge 1 commit into
Open
alessandrolattao wants to merge 1 commit into
alessandrolattao wants to merge 1 commit into
Conversation
EventBridge adds a replay-name field to every event it replays from an archive. CloudWatchEvent had no field for it, so a handler could not tell a replayed event from a live one. The field is omitempty, so an event that was not replayed marshals to the same JSON as before. Fixes aws#651
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 37 37
Lines 1487 1487
=======================================
Hits 1220 1220
Misses 264 264
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #651
Description of changes:
EventBridge adds a
replay-namefield to every event it replays from an archive.CloudWatchEvent(and its aliasEventBridgeEvent) has no field for it, so a Go handler cannot tell a replayed event from a live one without decoding the envelope itself. This addsReplayName, empty on a live delivery. The field isomitempty, so an event that was not replayed marshals to the same JSON as before.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
References
@types/aws-lambda(EventBridgeEvent["replay-name"]), Powertools for AWS Lambda Python (EventBridgeEvent.replay_name) and TypeScript (EventBridgeSchema)