Repository navigation
fix: Check for loops and invalide children (fixes #1935) - #1947
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused guards preserve valid-component behavior and regression tests cover both affected paths; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes #1935 by preventing bUnit’s render-tree traversal from following uninstantiated child components after a render failure.
Changes:
- Skip invalid child frames during markup generation and component discovery.
- Add regression tests for both paths and document the fix.
| File | Description |
|---|---|
| tests/bunit.tests/Rendering/BunitRendererTest.cs | Tests traversal after child construction fails. |
| src/bunit/Rendering/Internal/Htmlizer.cs | Skips uninstantiated children during markup generation. |
| src/bunit/Rendering/BunitRenderer.cs | Skips uninstantiated children during component discovery. |
| CHANGELOG.md | Documents the stack-overflow fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.