Repository navigation
Secure CLI browser login with state and PKCE - #22
Merged
Merged
Conversation
jsibbison-square
marked this pull request as ready for review
October 15, 2026 02:53
baxen
approved these changes
Oct 18, 2026
| @@ -146,8 +148,13 @@ fn run_browser_login_inner( | |||
| let code = rx | |||
| .recv() | |||
There was a problem hiding this comment.
Suggestion (non-blocking): this recv() waits forever. That was already the case, but it matters more now. A mismatched-state callback used to end the run with an error; now it's deliberately ignored. So a user who hits a stale tab sees "Sign-in didn't finish" in the browser while the CLI hangs until Ctrl-C. Consider recv_timeout (~10 min) with a "login timed out, rerun bl auth login" error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI browser login now generates fresh random state and an S256 PKCE challenge for each attempt. It rejects callbacks with missing, mismatched, or duplicate state, and sends the in-memory verifier when exchanging the code before verifying and storing the session. This binds the callback and code exchange to the initiating CLI login.
Keeps Blox proxy authentication unchanged, updates the auth-flow documentation, and consolidates overlapping tests and mock-server helpers.
Validation:
just checkpassed: formatting, Clippy, and all 350 tests, including Blox auth bypass coverage.https://test.blockstaging.buildcompleted successfully and the issued session passed/v1/auth/meverification.