Repository navigation
test: cover flask and connexion request and response extractors - #141
Merged
Merged
Conversation
Test remote user, header fallback, correlation id handling outside a request context, request log fields and app validation for the Flask and Connexion integrations. Refs #137 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #137 (item 6).
Adds
tests/test_flask_extractors.py(request log fields, basic-auth remote user, non-Flask app rejected, no current request / correlation id outside a request context, header fallback) andtests/test_connexion_extractors.py(extractor and response-extractor methods with stand-in request/response objects, non-Connexion app rejected).Coverage (this branch alone, on master): Flask 87% -> 96%, Connexion 78% -> 91%.
Tested: Python 3.14.6 on Windows; 107 passed (unit suite excluding smoke tests and gunicorn). The Connexion tests use stand-in objects rather than a running Connexion app; the Connexion 3 request-context behaviour stays covered by
test_correlation_outside_request.py. Not run on other Python versions.