Skip to content

test: cover request discovery, exception text and fastapi/quart extractors - #145

Merged
cvas22 merged 1 commit into
masterfrom
test/137-remaining-gaps
Oct 24, 2026
Merged

cvas22 merged 1 commit into
masterfrom
test/137-remaining-gaps

Conversation

@cvas22

@cvas22 cvas22 commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Closes #144. Also relates to #137.

Adds tests/test_request_discovery.py, tests/test_fastapi_quart_extractors.py and one config_root_logger test in tests/test_init_validation.py.

Coverage (local, Python 3.14.6, Windows): 92% -> 94%; util.py 96% -> 99%, fastapi/implementation.py 94% -> 98%, quart/__init__.py 88% -> 96%, formatters.py 98% -> 99%.

Tested: unit suite 157 passed, 1 skipped (gunicorn is not installable on Windows); strict flake8 selection is clean. Smoke tests for all four backends also pass locally (they need the package importable). Not run on other Python versions.

Not addressed: the Sanic test client's Task was destroyed but it is pending log at teardown, which does not fail a test; it is listed in the issue for follow-up.

…ctors

Add tests for call-stack request discovery, cached exception text,
config_root_logger, and the FastAPI and Quart request info extractors.

Refs #144

Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e30bea9a-87f8-4a06-901d-8e4bb62e3863
Commits

Reviewing files that changed from the base of the PR and between 1f49248 and 0fc49ca.

Files selected for processing: 3
  • tests/test_fastapi_quart_extractors.py
  • tests/test_init_validation.py
  • tests/test_request_discovery.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@llamapreview llamapreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LlamaPReview — Review skipped

This repository has used its free review capacity for today (3 reviews per UTC day). Capacity resets at 2026-10-25T00:00:00Z.

LlamaPReview is free for public repositories and funded personally, so a daily bound keeps one high-volume repository from consuming the shared budget. Nothing about this pull request was judged. You can also run LlamaPReview yourself with your own provider key — see Self-hosting.

No model-driven code review was run; this result does not assess whether the PR is ready to merge.

@cvas22
cvas22 merged commit 77239c0 into master Oct 24, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close remaining unit test gaps and tidy test noise

1 participant