Repository navigation
Conversation
Entries were stat'ed following links, so symlinks were reported with their target's type and dangling symlinks were skipped. That made Zig's deleteTree loop forever on directories containing a dangling link. Re-enables the Zig std tests "statFile on dangling symlink" and "readlinkat".
andreaTP
force-pushed
the
fix/fd-readdir-nofollow
branch
from
November 2, 2026 15:01
f535756 to
80475ef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fd_readdirstat'ed entries following symlinks: links got their target's type and dangling links were skipped, which made Zig'sdeleteTreeloop forever.Re-enables the Zig std tests "statFile on dangling symlink" and "readlinkat" (nightly: 2680 passed, 123 skipped, 0 failed).